OpenConceptLab/ocl_online#51 | Block Anonymous API usage except from approved clients#845
Open
snyaggarwal wants to merge 2 commits intomasterfrom
Open
OpenConceptLab/ocl_online#51 | Block Anonymous API usage except from approved clients#845snyaggarwal wants to merge 2 commits intomasterfrom
snyaggarwal wants to merge 2 commits intomasterfrom
Conversation
… approved clients
snyaggarwal
changed the title
paynejd
changed the title
paynejd
requested changes
Apr 9, 2026
Member
paynejd
left a comment
paynejd
left a comment
There was a problem hiding this comment.
Overall the design is clean and well-structured — each bypass mechanism is a separate method, easy to test and extend. Good test coverage too. A few things to address before merging, most importantly the X-Forwarded-For spoofing risk.
Typo in PR title: "Anonymouse" → "Anonymous"
paynejd
approved these changes
Apr 9, 2026
Member
paynejd
left a comment
paynejd
left a comment
There was a problem hiding this comment.
All six review comments addressed cleanly:
- X-Forwarded-For spoofing — resolved by only trusting
REMOTE_ADDR - Query string API keys — removed; header-only (
X-API-KEY/Authorization) - Short-circuit evaluation —
orchains instead ofany()tuple - Dead
''in exempt_exact_paths — removed get_set_from_env— renamed + returns a set for O(1) lookups- Test coverage gaps — all four added (query param rejection, forwarded IP rejection, whitespace header, disabled setting)
Minor nit: first commit message still has "Anonymouse" typo — not blocking.
LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes OpenConceptLab/ocl_online#51