Skip to content

fix(docker): improve dockerignore list - #3986

Draft
EmilyRagan wants to merge 2 commits into
mainfrom
dockerignore
Draft

EmilyRagan wants to merge 2 commits into
mainfrom
dockerignore

Conversation

@EmilyRagan

Copy link
Copy Markdown
Contributor

What changed

Added depth matching to openc3/.dockerignore

Why it changed

  • Python tests (at openc3/python/test) were being copied into the image because the ignore path only matched openc3/test/ -- this was adding ~200 unnecessary files to the published images
  • for local builds, local python/.venv (and other paths) was being copied into the image and overwriting the image's uv-built .venv because the ignore path only matched openc3/.venv -- this is only an improvement/fix/change for locally built images, not published ones

Testing strategy

CI building images

Compared image sizes locally:

main branch diff
Uncompressed, sum of layer sizes (docker history) 1,679,073,280 B 1,673,703,424 B −5.37 MB (−0.32%)
Uncompressed, files under /openc3 366,994,945 B (10,264 files) 364,851,397 B (10,056 files) −2.14 MB (−208 files)
Compressed (docker image inspect) 584,984,929 B 584,414,301 B −0.57 MB (−0.10%)

Review notes

n/a

@EmilyRagan EmilyRagan self-assigned this Oct 1, 2026
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.05%. Comparing base (0d8985e) to head (1ed775c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3986      +/-   ##
==========================================
- Coverage   80.06%   80.05%   -0.02%     
==========================================
  Files         901      901              
  Lines       68370    68370              
  Branches     2699     2699              
==========================================
- Hits        54738    54731       -7     
- Misses      12976    12983       +7     
  Partials      656      656              
Flag Coverage Δ
python 80.13% <ø> (+<0.01%) ⬆️
ruby-api 82.44% <ø> (-0.17%) ⬇️
ruby-backend 85.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant