fix(docker): improve dockerignore list - #3986
Draft
EmilyRagan wants to merge 2 commits into
Draft
EmilyRagan wants to merge 2 commits into
EmilyRagan wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3986 +/- ##
==========================================
- Coverage 80.06% 80.05% -0.02%
==========================================
Files 901 901
Lines 68370 68370
Branches 2699 2699
==========================================
- Hits 54738 54731 -7
- Misses 12976 12983 +7
Partials 656 656
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changed
Added depth matching to
openc3/.dockerignoreWhy it changed
openc3/python/test) were being copied into the image because the ignore path only matchedopenc3/test/-- this was adding ~200 unnecessary files to the published imagespython/.venv(and other paths) was being copied into the image and overwriting the image's uv-built.venvbecause the ignore path only matchedopenc3/.venv-- this is only an improvement/fix/change for locally built images, not published onesTesting strategy
CI building images
Compared image sizes locally:
docker history)/openc3docker image inspect)Review notes
n/a