Skip to content

Add standard Plugin Workflows - #3860

Open
ryanmelt wants to merge 1 commit into
mainfrom
standard_plugin_workflows
Open

ryanmelt wants to merge 1 commit into
mainfrom
standard_plugin_workflows

Conversation

@ryanmelt

Copy link
Copy Markdown
Member

What changed

Added release, unit test, and playwright install test workflows for new plugins

Why it changed

Plugins having standard test and release workflows

Testing strategy

Tested indirectly with new Kayhan plugin

Review notes

Make sure this will work generically with all plugins.

@ryanmelt

Copy link
Copy Markdown
Member Author

Requires this PR first OpenC3/.github#9

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.47%. Comparing base (aa0c194) to head (180fcc5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3860      +/-   ##
==========================================
- Coverage   79.58%   79.47%   -0.11%     
==========================================
  Files         901      901              
  Lines       68067    68067              
  Branches     2633     2684      +51     
==========================================
- Hits        54171    54099      -72     
- Misses      13222    13305      +83     
+ Partials      674      663      -11     
Flag Coverage Δ
frontend 65.91% <ø> (-0.47%) ⬇️
python 79.49% <ø> (+<0.01%) ⬆️
ruby-api 82.15% <ø> (-0.33%) ⬇️
ruby-backend 85.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryanmelt
ryanmelt requested a review from jmthomas September 22, 2026 21:26

@jmthomas jmthomas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing templates are setup such that if you go to the Actions tab and click New workflow:

Image

You get the option to choose one by OpenC3:

Image

This is nice for putting something directly in a new template spawned from the CLI but I think we should unify these somehow.

# A tool or widget frontend needs nothing set here: once the plugin has a
# package.json it is built with pnpm before the gem is packaged.

name: Release

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this: https://github.com/OpenC3/.github/blob/main/workflow-templates/release-cosmos-plugin.yml. I'd rather you make the changes there than add a new workflow.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that these are separate things but I would still like for them to be somehow unified.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmthomas I'm not sure how they would be more unified -- this is "include a GitHub workflow in any generated plugin that will automatically use the OpenC3-provided release workflow"

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants