Skip to content

feat(desktop): improve macOS chrome and expand preset employees - #192

Merged
hm1229 merged 5 commits into
OpenBMB:mainfrom
coder-zkl1988:agent/desktop-login-window-chrome
Aug 19, 2026
Merged

feat(desktop): improve macOS chrome and expand preset employees#192
hm1229 merged 5 commits into
OpenBMB:mainfrom
coder-zkl1988:agent/desktop-login-window-chrome

Conversation

@coder-zkl1988

@coder-zkl1988 coder-zkl1988 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • allow a unique tenant-scoped display name to be used as a login identifier while preserving username priority
  • improve the macOS titlebarless window with a safe drag region and double-click zoom support
  • move sidebar branding and chat header controls below the native macOS drag area
  • add five preset employees for procurement, project management, sales, data analysis, and marketing
  • preserve existing knowledge-base version references during SQLite startup migration
  • retain the existing StaffDeck landing/login interface

Why

Regular users need to sign in with the display name shown by StaffDeck after an administrator changes their password. The macOS desktop shell also needs a usable drag target without overlapping page controls. The additional preset employees make the default workspace more complete, while the migration guard prevents legacy knowledge-base rows from conflicting with generated version identifiers.

The proposed replacement login design was removed so this PR keeps the current landing-page experience.

User impact

  • users can sign in with either their username or a unique display name within the tenant
  • macOS users can drag and double-click zoom the titlebarless window without blocking sidebar, rename, or account controls
  • new installations include five additional ready-to-use employee profiles and their seeded resources
  • existing SQLite installations retain noncanonical knowledge-base version identifiers safely
  • the current login-page layout remains unchanged

Validation

  • python -m pytest backend/tests/test_desktop_launcher.py backend/tests/test_auth_roles.py backend/tests/test_staffdeck_seed.py backend/tests/test_database_config.py (64 passed)
  • npm --prefix frontend-enterprise test -- --run src/pages/LoginPage.test.tsx src/employee.test.ts (10 passed)
  • npm --prefix frontend-enterprise run build
  • npm --prefix frontend-enterprise run i18n:check
  • npm --prefix frontend-enterprise run config:check
  • built a macOS arm64 StaffDeck.app with PyInstaller
  • packaged executable import smoke test passed
  • packaged app started successfully and passed /api/health
  • browser verification covered the restored landing page, admin/admin login, and all five added preset employees

@coder-zkl1988
coder-zkl1988 marked this pull request as ready for review August 18, 2026 12:28
@coder-zkl1988

Copy link
Copy Markdown
Contributor Author
img_v3_0214m_9fdac70a-179c-484c-9381-041919c071ag

@coder-zkl1988

Copy link
Copy Markdown
Contributor Author
image

@hm1229
hm1229 self-requested a review August 19, 2026 06:21
@hm1229 hm1229 self-assigned this Aug 19, 2026
@hm1229 hm1229 changed the title feat(desktop): redesign login and improve macOS window chrome feat(desktop): improve macOS chrome and expand preset employees Aug 19, 2026
@hm1229
hm1229 merged commit 83d1eef into OpenBMB:main Aug 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants