fix(repo): anchor the remaining config.*.yaml ignore rule to the repository root - #268
Merged
himanshu231204 merged 1 commit intoAug 1, 2026
Conversation
A bare config.*.yaml pattern matches at any depth, so it silently ignores example configs under examples/. Anchoring it to /config.*.yaml keeps the developer-secret protection at the root while allowing nested example configs to be tracked normally. Drop the redundant config.groq.yaml line: the anchored wildcard already covers it. Co-Authored-By: Kimi K2.7 Code <noreply@kimi.com>
|
🎉 Congratulations @Nitjsefnie! Your pull request has been successfully merged into main. 🚀 Thank you for contributing to OpenAgentHQ and helping improve the project. We truly appreciate your contribution and hope to see you back with more amazing PRs! Happy Open Sourcing! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #264. The sibling of #265, which you merged an hour ago.
#265anchoredconfig.yaml→/config.yaml. The wildcard rule one line below it was still unanchored, so it matched example configs anywhere in the tree:Same fix, same shape:
config.*.yaml→/config.*.yaml. Theconfig.groq.yamlline above it is dropped as redundant —git check-ignore -vattributes that path to the wildcard on 242, never to 241, since the wildcard is the last matching rule and already covers it.The section is now just:
Type of Change
Related Issues
Closes #264
How Has This Been Tested?
uv run pytest tests/unit -v --tb=short→ 1015 passed, 4 skippedBehavioural proof both directions, since that is the whole point of an ignore-rule fix:
Before — example configs wrongly ignored:
After — they are visible, and the rule still does its real job at the root:
Note
uv sync --all-extrastoucheduv.locklocally while setting up to run your tests; it is deliberately not staged, so this commit is.gitignoreand nothing else.Generated by Claude Opus 5 (brief, review), Kimi K2.7 Code (implementation)