ci: point the type-check step at the real package instead of a nonexistent src/ - #267
Merged
himanshu231204 merged 2 commits intoAug 1, 2026
Conversation
The CI mypy step targeted src/, which does not exist; the package lives at openagent_eval/. The || true kept the exit invisible. Point the check at openagent_eval and add a directory guard so a missing target fails loudly instead of being swallowed again. Co-Authored-By: Kimi K2.7 Code <noreply@kimi.com>
|
🎉 Congratulations @Nitjsefnie! Your pull request has been successfully merged into main. 🚀 Thank you for contributing to OpenAgentHQ and helping improve the project. We truly appreciate your contribution and hope to see you back with more amazing PRs! Happy Open Sourcing! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.github/workflows/ci.ymlpointed the type-check step atsrc, which does not exist — the package isopenagent_eval/at the repo root. mypy exited 2 withCannot read file 'src',|| trueswallowed it, and the step reported success, so the package has never actually been type-checked while appearing to be.This points the step at the real package and adds a
test -d openagent_evalguard first, because a path that cannot be read is a configuration error rather than a finding, and should not be able to hide behind|| trueagain.Your own PR template already names the correct path (
uv run mypy openagent_eval/), so the workflow was the only place still carryingsrc.Type of Change
Related Issues
Closes #250
How Has This Been Tested?
uv run pytest) — untouched by this changeuv run ruff check .) — untoucheduv run mypy openagent_eval/) — no, and that is the point of the issueBefore, on the old target:
After, on the real package:
YAML re-parsed to confirm the block is still valid.
I deliberately kept
|| true. Turning 121 pre-existing findings into a hard CI failure is your call, not something to smuggle into a path fix — and the neighbouring ruff steps are advisory the same way. The number is here so you can decide when it is worth dropping.Follow-ups / Known Limitations
One honest limit on the guard. The step also carries
continue-on-error: true, so a missing target now shows up as a failed step rather than a silently green one — but the job itself still passes. That is a real improvement in visibility over|| truereporting success, and it is as far as this change goes; making it actually fail the job means droppingcontinue-on-error, which is the same kind of decision as dropping|| trueand equally yours.I have not touched any of the 121 findings, and no type annotations were added — that backlog is a separate piece of work.
Generated by Claude Opus 5 (brief, review), Kimi K2.7 Code (implementation)