-
Notifications
You must be signed in to change notification settings - Fork 13
Feature/remove toc not included warnings #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
65762d0
fb5b5ce
5c3ee1f
928b7f8
6cab97a
600925d
5743f74
4ee9321
b5ec6e5
53ec627
b3dc08c
056d575
5877782
341780f
e7c0aa3
1c41fed
1197e65
b372fe0
26cd40a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,18 @@ | ||
| [submodule "open-amp"] | ||
| path = open-amp | ||
| url = https://github.com/OpenAMP/open-amp.git | ||
| url = https://github.com/sipke/open-amp.git | ||
| [submodule "hypervisorless_virtio_zcu102"] | ||
| path = hypervisorless_virtio_zcu102 | ||
| url = https://github.com/danmilea/hypervisorless_virtio_zcu102.git | ||
| url = https://github.com/sipke/hypervisorless_virtio_zcu102.git | ||
| [submodule "lopper"] | ||
| path = lopper | ||
| url = https://github.com/devicetree-org/lopper.git | ||
| url = https://github.com/sipke/lopper.git | ||
| [submodule "openamp-system-reference"] | ||
| path = openamp-system-reference | ||
| url = https://github.com/OpenAMP/openamp-system-reference.git | ||
| url = https://github.com/sipke/openamp-system-reference.git | ||
| [submodule "libmetal"] | ||
| path = libmetal | ||
| url = https://github.com/OpenAMP/libmetal.git | ||
| url = https://github.com/sipke/libmetal.git | ||
| [submodule "awesome"] | ||
| path = _doxygen/awesome | ||
| url = https://github.com/jothepro/doxygen-awesome-css.git |
| +2 −2 | README.md | |
| +11 −1 | zephyr_r5/hello_r5/README.rst |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,3 +17,52 @@ Welcome to the OpenAMP Project Documentation | |
| protocol_details/index | ||
| docs/porting_guide | ||
| openamp/glossary | ||
|
|
||
|
|
||
| .. | ||
| TOC entries used to suppress warnings we accept for files not included in a table of contents. | ||
| WARNING: document isn't included in any toctree [toc.not_included] | ||
| Note that each library's (e.g. open-amp) readme file is included via the REFERENCE section links | ||
| in the navigation bar on the left. | ||
|
|
||
| .. toctree:: | ||
| :hidden: | ||
|
|
||
| README | ||
| openamp-system-reference/README | ||
| openamp-system-reference/LICENSE | ||
| open-amp/.github/actions/build_ci/README | ||
| open-amp/README | ||
| open-amp/MAINTAINERS | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. generate page is empty ?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting. doxygen looks to have generated two files. The one you link is empty, the other has the content. The one with the expected content can be navigated to via REFERENCE, open-amp API, Maintainers.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This same issue seems to happen with the LICENSE file included in doxygen INPUT So these PR changes have not introduced this duplication of html file generation as detailed above. Dug into it a bit but haven't found root cause, but initial indication is possible conflict in naming causing doxygen to generate multiples, or something with the search indexing or both. Will change this out of draft and submit submodule PRs. If we want to figure out why the duplication its probably deserves an issue and separate investigation. |
||
| open-amp/LICENSE | ||
| libmetal/.github/actions/build_ci/README | ||
| libmetal/README | ||
| libmetal/MAINTAINERS | ||
| libmetal/LICENSE | ||
| lopper/LICENSE | ||
| lopper/specification/README | ||
| lopper/tests/MIGRATION_GUIDE | ||
| lopper/tests/README | ||
| lopper/README | ||
| lopper/README-architecture | ||
| lopper/specification/source/index | ||
| lopper/docs/amd/linux/source/index | ||
| lopper/docs/amd/zephyr/source/index | ||
| lopper/demos/openamp/README.md | ||
|
|
||
| .. | ||
| TOC entries for examples which do not have readthedocs descriptions so suppressing to avoid the | ||
| warning: | ||
| WARNING: document isn't included in any toctree [toc.not_included] | ||
| If readthedocs description is added, these should be integrated into that description. | ||
|
|
||
| .. toctree:: | ||
| :hidden: | ||
|
|
||
| openamp-system-reference/examples/legacy_apps/examples/nocopy_echo/README | ||
| openamp-system-reference/examples/legacy_apps/examples/rpmsg_sample_echo/README | ||
| openamp-system-reference/examples/libmetal/README | ||
| openamp-system-reference/examples/libmetal/demos/irq_shmem_demo/README | ||
| openamp-system-reference/examples/libmetal/demos/irq_shmem_demo/host/README | ||
| openamp-system-reference/examples/libmetal/demos/irq_shmem_demo/remote/README | ||
| openamp-system-reference/examples/zephyr/dual_qemu_ivshmem/README | ||
| +0 −2,769 | Doxyfile | |
| +1 −15 | doc/Doxyfile.in | |
| +1 −0 | lib/remoteproc/remoteproc.c |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,11 +4,10 @@ | |
| OpenAMP Supporting Tools | ||
| ========================= | ||
|
|
||
| Lopper | ||
| ------ | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Regarding https://openamp--82.org.readthedocs.build/en/82/tools/index.html#
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed table of contents caption to remove the duplicate |
||
| .. toctree:: | ||
| :maxdepth: 2 | ||
| :caption: Contents: | ||
|
|
||
| lopper | ||
| ../lopper/demos/openamp/README.md | ||
|
|
||
| * Run the Lopper Demonstration as demo5 in :ref:`Docker Images<docker-images-label>`. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,6 @@ | ||
| =================== | ||
| OpenAMP Lopper Tool | ||
| =================== | ||
|
|
||
| .. _lopper-tool-intro: | ||
|
|
||
| *************** | ||
| Lopper Intro | ||
| *************** | ||
| .. toctree:: | ||
| :maxdepth: 1 | ||
|
|
||
| System Device Trees (S-DT) are used to describe resources of `heterogeneous <https://en.wikipedia.org/wiki/Heterogeneous_computing>`_ embedded environments. | ||
|
|
||
| Their intent is to be the industry standard method for defining how computing resources are divided into independent :ref:`runtime domains<resource-assignment-work-label>`. | ||
|
|
||
| Examples of domains are | ||
|
|
||
| * a computing unit, e.g. RTOS on R5s | ||
| * an operating environment at a specific execution level (e.g. `OPTEE <https://optee.readthedocs.io/en/latest/general/about.html>`_) | ||
| * a virtual machine (e.g. `Xen <https://xenproject.org/>`_) | ||
|
|
||
| For those familiar with `Device Trees (DTS) <https://www.kernel.org/doc/html/latest/devicetree/usage-model.html>`_ think of the S-DT as a combination of multiple device trees to define sub-systems. DTS' define resources seen from one address space, whereas S-DT's define the topology of the full system. | ||
|
|
||
| The `Lopper Tool <https://github.com/devicetree-org/lopper>`_ provides a way to generate sub-system DTS' from S-DT's and manipulate, inspect or verify the S-DT for correctness. | ||
|
|
||
| .. image:: ../images/tools/lopper-intro.svg | ||
|
|
||
|
|
||
| The `Lopper Tool <https://github.com/devicetree-org/lopper>`_ is a data driven tool written in Python, and supports inputs in dts, dtb and yaml format. Actions, which are used to manipulate the input data, are provided as unit operations (lops) as DTS formatted files. These are small transformation commands, inline Python source or for more complex scenarios `lopper assists <https://github.com/devicetree-org/lopper/tree/master/lopper/assists>`_ Python modules. | ||
|
|
||
| The diagram below shows an example of three transformations performed by lopper through three independent DTS files which define the actions to perform. | ||
|
|
||
| .. image:: ../images/tools/lopper-actions.svg | ||
|
|
||
| Lopper is built on top of device tree tools, `Device Tree Compiler (DTC) <https://github.com/torvalds/linux/tree/master/scripts/dtc>`_ and `libfdt <https://github.com/torvalds/linux/tree/master/scripts/dtc/libfdt>`_. | ||
|
|
||
|
|
||
| References | ||
| ^^^^^^^^^^ | ||
|
|
||
| :ref:`Lopper Architecture Readme<lopper/README-architecture:lopper processing flow:>` | ||
|
|
||
| `Linaro Connect 2020 - System Device Tree & Lopper Slide Set <https://static.linaro.org/connect/lvc20/presentations/LVC20-314-0.pdf>`_ | ||
|
|
||
| `Open Source Summit 2022 Slide Set <https://static.sched.com/hosted_files/ossna2022/d9/Lopper%20ELCNA%202022.pdf>`_ | ||
| lopper_intro |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
|
|
||
| .. _lopper-tool-intro: | ||
|
|
||
| ==================== | ||
| OpenAMP Lopper Intro | ||
| ==================== | ||
|
|
||
| System Device Trees (S-DT) are used to describe resources of `heterogeneous <https://en.wikipedia.org/wiki/Heterogeneous_computing>`_ embedded environments. | ||
|
|
||
| Their intent is to be the industry standard method for defining how computing resources are divided into independent :ref:`runtime domains<resource-assignment-work-label>`. | ||
|
|
||
| Examples of domains are | ||
|
|
||
| * a computing unit, e.g. RTOS on R5s | ||
| * an operating environment at a specific execution level (e.g. `OPTEE <https://optee.readthedocs.io/en/latest/general/about.html>`_) | ||
| * a virtual machine (e.g. `Xen <https://xenproject.org/>`_) | ||
|
|
||
| For those familiar with `Device Trees (DTS) <https://www.kernel.org/doc/html/latest/devicetree/usage-model.html>`_ think of the S-DT as a combination of multiple device trees to define sub-systems. DTS' define resources seen from one address space, whereas S-DT's define the topology of the full system. | ||
|
|
||
| The `Lopper Tool <https://github.com/devicetree-org/lopper>`_ provides a way to generate sub-system DTS' from S-DT's and manipulate, inspect or verify the S-DT for correctness. | ||
|
|
||
| .. image:: ../images/tools/lopper-intro.svg | ||
|
|
||
|
|
||
| The `Lopper Tool <https://github.com/devicetree-org/lopper>`_ is a data driven tool written in Python, and supports inputs in dts, dtb and yaml format. Actions, which are used to manipulate the input data, are provided as unit operations (lops) as DTS formatted files. These are small transformation commands, inline Python source or for more complex scenarios `lopper assists <https://github.com/devicetree-org/lopper/tree/master/lopper/assists>`_ Python modules. | ||
|
|
||
| The diagram below shows an example of three transformations performed by lopper through three independent DTS files which define the actions to perform. | ||
|
|
||
| .. image:: ../images/tools/lopper-actions.svg | ||
|
|
||
| Lopper is built on top of device tree tools, `Device Tree Compiler (DTC) <https://github.com/torvalds/linux/tree/master/scripts/dtc>`_ and `libfdt <https://github.com/torvalds/linux/tree/master/scripts/dtc/libfdt>`_. | ||
|
|
||
| Run the Lopper Demonstration as demo5 in :ref:`Docker Images<docker-images-label>`. | ||
|
|
||
|
|
||
| References | ||
| ^^^^^^^^^^ | ||
|
|
||
| `Linaro Connect 2020 - System Device Tree & Lopper Slide Set <https://static.linaro.org/connect/lvc20/presentations/LVC20-314-0.pdf>`_ | ||
|
|
||
| `Open Source Summit 2022 Slide Set <https://static.sched.com/hosted_files/ossna2022/d9/Lopper%20ELCNA%202022.pdf>`_ | ||
|
|
||
| `Lopper Repository <https://github.com/devicetree-org/lopper>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should not rework the readme files
../openamp-system-reference/examples/legacy_apps/README should perhaps describe how to set the compilation environment , and we should remove the
Run application on a Linux PCchapter.Link to openamp-system-reference/examples/legacy_apps/README in ../openamp-system-reference/examples/legacy_apps/examples/echo/README seems broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, adjusting readme files to suit inclusion into openamp docs would make sense.
Yes, as mentioned in the PR summary (second last paragraph) some links are broken as they do not use sphinx references. I did not fix those for this draft pull request as was just showing how the toc not included warnings can be corrected as example before proceeding to address all as there are quite some.