Conversation
wmamills
left a comment
wmamills
left a comment
There was a problem hiding this comment.
- Drop layer compat from your PRs I will do my own
- Separate common code changes in one PR and xilinx vendor changes in another
conf/layer.conf
Outdated
|
|
||
| # only for Xilinx petalinux | ||
| LAYERSERIES_COMPAT_openamp-layer += "langdale" | ||
| LAYERSERIES_COMPAT_openamp-layer = "scarthgap" |
There was a problem hiding this comment.
Absolutely not. We need to support master, latest release, LTS. We can and should support LTS-1 (now kickstone) when we can and I think we can now. We could not when LTS-1 was dunfell.
I will make my own PR to update this. Please take it out of this PR.
| S = "${WORKDIR}/git/examples/linux/rpmsg-proxy-app" | ||
|
|
||
| RRECOMMENDS:${PN} = "kernel-module-rpmsg-char" | ||
| RRECOMMENDS:${PN} = "kernel-module-rpmsg-char kernel-module-rpmsg-ctrl" |
There was a problem hiding this comment.
These other common layer changes look OK to me for now. I will test when I get home (traveling this week)
However I would like to see this PR split between the common level changes and another PR for the stuff in the xilinx/ layer. I wont review the xilinx stuff so I don't want to sign off on it. Whatever you (ben) and Mark want in the Xilinx vendor dir is OK with me but it should be approved by the both of you.
Move vendor specific logic to vendor specific layers Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
Versal was recently split between versal and versal-net, add versal-net as supported. Signed-off-by: Mark Hatle <mark.hatle@amd.com>
Remove openamp support for Zynq-7000 Soc Reasons for removing listed below: 1 - Removing redundant or unmaintained code from Linux tree 2 - Reduce technical debt carried by OpenAMP team 3 - OpenAMP drivers (remoteproc/rpmsg) for Zynq-7000 SoC is not standardized on same code base as ZynqMP or Versal 4 - very few customer using openamp on Zynq-7000 SoC For users of Zynq-7000 SoC the last working and tested release version is rel-v2023.2 Signed-off-by: Rajiv Mohan <rajiv.mohan@amd.com> - Fix typo in yocto-cmake-translation.bbclass. Signed-off-by: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@amd.com> classes/yocto-cmake-translation.bbclass: Remove comment referring to zynq7 Signed-off-by: Mark Hatle <mark.hatle@amd.com>
no_ipi_setup is not used with latest build setup so remove this Signed-off-by: Ben Levinsky <ben.levinsky@amd.com> Signed-off-by: Mark Hatle <mark.hatle@amd.com>
rpmsg-ctrl module required for demos to run Signed-off-by: Ben Levinsky <ben.levinsky@amd.com> Signed-off-by: Mark Hatle <mark.hatle@amd.com>
Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
bentheredonethat
force-pushed
the
25.1-updates
branch
from
2aab4ee to
602992a
Compare
|
@wmamills updated also in our own layers we have moved the vendor specific SDT logic to internal layers so removed out all those changes. |
4 participants
Pull in Commits from https://github.com/Xilinx/meta-openamp/tree/rel-v2025.1