Skip to content

Svc: drop periodic Sched/Ping ticks on queue-full instead of asserting #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mikefly123 wants to merge 1 commit into from
Open

Svc: drop periodic Sched/Ping ticks on queue-full instead of asserting #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Svc/ActiveRateGroup/ActiveRateGroup.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module Svc {
output port RateGroupMemberOut: [ActiveRateGroupOutputPorts] Sched

@ Ping input port for health
async input port PingIn: Ping
async input port PingIn: Ping drop

@ Ping output port for health
output port PingOut: Ping
Expand Down
4 changes: 2 additions & 2 deletions Svc/BufferLogger/BufferLogger.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ module Svc {
async input port comIn: Fw.Com

@ Ping input port
async input port pingIn: Svc.Ping
async input port pingIn: Svc.Ping drop

@ Ping output port
output port pingOut: Svc.Ping

async input port schedIn: Svc.Sched
async input port schedIn: Svc.Sched drop

# ----------------------------------------------------------------------
# Special ports
Expand Down
4 changes: 2 additions & 2 deletions Svc/CmdDispatcher/CmdDispatcher.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ module Svc {
async input port seqCmdBuff: [CmdDispatcherSequencePorts] Fw.Com hook

@ Ping input port
async input port pingIn: Svc.Ping
async input port pingIn: Svc.Ping drop

@ Run port used to emit telemetry
async input port run: Svc.Sched
async input port run: Svc.Sched drop

@ Ping output port
output port pingOut: Svc.Ping
Expand Down
4 changes: 2 additions & 2 deletions Svc/CmdSequencer/CmdSequencer.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ module Svc {
async input port cmdResponseIn: Fw.CmdResponse

@ Ping in port
async input port pingIn: Svc.Ping
async input port pingIn: Svc.Ping drop

@ Ping out port
output port pingOut: Svc.Ping
Expand All @@ -86,7 +86,7 @@ module Svc {
output port comCmdOut: Fw.Com

@ Schedule in port
async input port schedIn: Svc.Sched
async input port schedIn: Svc.Sched drop

@ Notifies that a sequence has started running
output port seqStartOut: Svc.CmdSeqIn
Expand Down
2 changes: 1 addition & 1 deletion Svc/ComLogger/ComLogger.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module Svc {
async input port comIn: Fw.Com

@ Ping input port
async input port pingIn: Svc.Ping
async input port pingIn: Svc.Ping drop

@ Ping output port
output port pingOut: Svc.Ping
Expand Down
2 changes: 1 addition & 1 deletion Svc/DpCatalog/DpCatalog.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ module Svc {
# Component specific ports

@ Ping input port
async input port pingIn: Svc.Ping
async input port pingIn: Svc.Ping drop

@ Ping output port
output port pingOut: Svc.Ping
Expand Down
2 changes: 1 addition & 1 deletion Svc/DpManager/DpManager.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module Svc {
# ----------------------------------------------------------------------

@ Schedule in port
async input port schedIn: Svc.Sched
async input port schedIn: Svc.Sched drop

# ----------------------------------------------------------------------
# Ports for handling buffer requests
Expand Down
2 changes: 1 addition & 1 deletion Svc/DpWriter/DpWriter.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module Svc {
# ----------------------------------------------------------------------

@ Schedule in port
async input port schedIn: Svc.Sched
async input port schedIn: Svc.Sched drop

# ----------------------------------------------------------------------
# Ports for handling data products
Expand Down
2 changes: 1 addition & 1 deletion Svc/EventManager/EventManager.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ module Svc {
output port FatalAnnounce: Svc.FatalEvent

@ Ping input port
async input port pingIn: Svc.Ping
async input port pingIn: Svc.Ping drop

@ Ping output port
output port pingOut: Svc.Ping
Expand Down
4 changes: 2 additions & 2 deletions Svc/FileDownlink/FileDownlink.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module Svc {
# ----------------------------------------------------------------------

@ Run input port
async input port Run: Svc.Sched
async input port Run: Svc.Sched drop

@ Mutexed Sendfile input port
guarded input port SendFile: Svc.SendFileRequest
Expand All @@ -23,7 +23,7 @@ module Svc {
output port bufferSendOut: Fw.BufferSend

@ Ping input port
async input port pingIn: Svc.Ping
async input port pingIn: Svc.Ping drop

@ Ping output port
output port pingOut: Svc.Ping
Expand Down
2 changes: 1 addition & 1 deletion Svc/FileManager/FileManager.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module Svc {
# ----------------------------------------------------------------------

@ Ping input port
async input port pingIn: Svc.Ping
async input port pingIn: Svc.Ping drop

@ Scheduler input port for rate group operations
sync input port schedIn: Sched
Expand Down
2 changes: 1 addition & 1 deletion Svc/FileUplink/FileUplink.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module Svc {
output port bufferSendOut: Fw.BufferSend

@ Ping in
async input port pingIn: Svc.Ping
async input port pingIn: Svc.Ping drop

@ Ping out
output port pingOut: Svc.Ping
Expand Down
2 changes: 1 addition & 1 deletion Svc/FpySequencer/FpySequencer.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ module Svc {

@ Ping in port
# TODO should ping have highest prio? or lowest?
async input port pingIn: Svc.Ping priority 10 assert
async input port pingIn: Svc.Ping priority 10 drop

@ port to trigger a wakeup or timeout check. increase frequency
@ to increase temporal resolution of sequencer
Expand Down
2 changes: 1 addition & 1 deletion Svc/PrmDb/PrmDb.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ module Svc {
async input port setPrm: Fw.PrmSet

@ Ping input port
async input port pingIn: Svc.Ping
async input port pingIn: Svc.Ping drop

@ Ping output port
output port pingOut: Svc.Ping
Expand Down
4 changes: 2 additions & 2 deletions Svc/TlmChan/TlmChan.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ module Svc {
guarded input port TlmGet: Fw.TlmGet

@ Run port for starting packet send cycle
async input port Run: Svc.Sched
async input port Run: Svc.Sched drop

@ Packet send port
output port PktSend: Fw.Com

@ Ping input port
async input port pingIn: Svc.Ping
async input port pingIn: Svc.Ping drop

@ Ping output port
output port pingOut: Svc.Ping
Expand Down
4 changes: 2 additions & 2 deletions Svc/TlmPacketizer/TlmPacketizer.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ module Svc {
async input port controlIn: EnableSection

@ Ping input port
async input port pingIn: Svc.Ping
async input port pingIn: Svc.Ping drop

@ Ping output port
output port pingOut: Svc.Ping

@ Run port for starting packet send cycle
async input port Run: Svc.Sched
async input port Run: Svc.Sched drop

@ Input configuration port
async input port configureSectionGroupRate: ConfigureGroupRate
Expand Down
Loading