Skip to content

fix(config): BUFFER_FANOUT_MAX_BUFFERS_IN_FLIGHT 10 → 40 - #1

Open
Mikefly123 wants to merge 3 commits into
mainfrom
fix/471-fanout-map-capacity
Open

Mikefly123 wants to merge 3 commits into
mainfrom
fix/471-fanout-map-capacity

Conversation

@Mikefly123

Copy link
Copy Markdown

Problem

BufferCollector/BufferRepeater track in-flight buffers in a fixed-size ArrayMap sized by BUFFER_FANOUT_MAX_BUFFERS_IN_FLIGHT = 10. When more buffers pass through than the map holds, the insert FW_ASSERTs (BufferCollector.cpp:36) and the deployment dies.

Any project whose buffer pool exceeds 10 hits this as a FATAL: on PROVES flight hardware, a 25-buffer comms pool backing up through fileUplinkCollector during an SD write stall produced exactly this cascade (Open-Source-Space-Foundation/proves-core-reference#471), leaving the board byte-silent until power cycle.

Fix

Raise the constant to 40 (~8 bytes/entry, negligible RAM), documenting that it must be at least as large as any buffer pool routed through a collector/repeater. Longer-term this should become a per-instance config parameter sized to the feeding pool; this is the minimal safe fix.

Verification

With this + companion fprime/proves-core-reference changes: full UART file-transfer integration suite green from one boot on the hardware that reproduced the FATAL, including induced pool-exhaustion runs.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WpBURCutAx8281i59nj6fo

nateinaction and others added 2 commits May 17, 2026 19:20
BufferCollector/BufferRepeater track in-flight buffers in a fixed-size
ArrayMap; when more buffers pass through than the map holds, the insert
FW_ASSERTs (BufferCollector.cpp:36) and the deployment dies. Any project
whose buffer pool exceeds 10 (e.g. PROVES flight: 25-buffer comms pool
backing up through fileUplinkCollector during an SD write stall) hits this
as a FATAL cascade -- observed on hardware as issue
Open-Source-Space-Foundation/proves-core-reference#471.

40 covers realistic pool sizes at ~8 bytes/entry. Ideally this becomes a
per-instance template/config parameter sized to the feeding pool; the
constant bump is the minimal safe fix.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WpBURCutAx8281i59nj6fo
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Mikefly123, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b7f48140-9264-4079-9f3f-e44be91ea216

📥 Commits

Reviewing files that changed from the base of the PR and between 1d82b88 and 6f3e645.

📒 Files selected for processing (10)
  • FprimeExtras/FprimeExtrasConfig/ExtrasConfig/BufferRepeaterConfig.fpp
  • FprimeExtras/Utilities/CMakeLists.txt
  • FprimeExtras/Utilities/ComRetry/CMakeLists.txt
  • FprimeExtras/Utilities/ComRetry/ComRetry.cpp
  • FprimeExtras/Utilities/ComRetry/ComRetry.fpp
  • FprimeExtras/Utilities/ComRetry/ComRetry.hpp
  • FprimeExtras/Utilities/ComRetry/docs/sdd.md
  • FprimeExtras/Utilities/ComRetry/test/ut/ComRetryTestMain.cpp
  • FprimeExtras/Utilities/ComRetry/test/ut/ComRetryTester.cpp
  • FprimeExtras/Utilities/ComRetry/test/ut/ComRetryTester.hpp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants