fix(config): BUFFER_FANOUT_MAX_BUFFERS_IN_FLIGHT 10 → 40 - #1
Mikefly123 wants to merge 3 commits into
Conversation
BufferCollector/BufferRepeater track in-flight buffers in a fixed-size ArrayMap; when more buffers pass through than the map holds, the insert FW_ASSERTs (BufferCollector.cpp:36) and the deployment dies. Any project whose buffer pool exceeds 10 (e.g. PROVES flight: 25-buffer comms pool backing up through fileUplinkCollector during an SD write stall) hits this as a FATAL cascade -- observed on hardware as issue Open-Source-Space-Foundation/proves-core-reference#471. 40 covers realistic pool sizes at ~8 bytes/entry. Ideally this becomes a per-instance template/config parameter sized to the feeding pool; the constant bump is the minimal safe fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WpBURCutAx8281i59nj6fo
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…fanout-map-capacity
Problem
BufferCollector/BufferRepeatertrack in-flight buffers in a fixed-sizeArrayMapsized byBUFFER_FANOUT_MAX_BUFFERS_IN_FLIGHT = 10. When more buffers pass through than the map holds, the insert FW_ASSERTs (BufferCollector.cpp:36) and the deployment dies.Any project whose buffer pool exceeds 10 hits this as a FATAL: on PROVES flight hardware, a 25-buffer comms pool backing up through
fileUplinkCollectorduring an SD write stall produced exactly this cascade (Open-Source-Space-Foundation/proves-core-reference#471), leaving the board byte-silent until power cycle.Fix
Raise the constant to 40 (~8 bytes/entry, negligible RAM), documenting that it must be at least as large as any buffer pool routed through a collector/repeater. Longer-term this should become a per-instance config parameter sized to the feeding pool; this is the minimal safe fix.
Verification
With this + companion fprime/proves-core-reference changes: full UART file-transfer integration suite green from one boot on the hardware that reproduced the FATAL, including induced pool-exhaustion runs.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WpBURCutAx8281i59nj6fo