Repository navigation
Conversation
The JSON report reads a finding's rule from Diagnostic::code since Open-MBEE#10, but the context stage wrote the rule only into the message, and a few findings that violate a named rule did not name it. The opensysml baselines move only in message text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29. Follow-up to #10.
The context stage now sets
Diagnostic::codefor the findings that name arule, so
check --format jsonreports theirrule. Six owning-type rulesand the name clash get their rule name, and four semantic findings name the
rule they report. No finding is added or removed, and no severity changes.
How to test
Look closely at
sysmlv2-syntax/src/check.rsgets arule_errorhelper that writes"rule: message" and sets the code, the style the context stage already
used. The semantic stage keeps its "message [rule]" style.
IMPLEMENTED_NORMATIVE_VALIDATION_RULESandIMPLEMENTED_NORMATIVE_SEMANTIC_RULES, and the XMI audit accepts them.for one. No finding is added or lost.
verifymember in the wrong body had a context and a semantic findingbefore; both now name
validateRequirementVerificationMembershipOwningType.CHANGELOG.mdentry is under a newUnreleasedheading. Move or dropit as you prefer.