Repository navigation
Conversation
KerML 8.3.4.7.3 and 8.3.4.7.4 count the owned and the inherited return parameters, so `function G :> F, H;` with a return in each general violates validateFunctionResultParameterMembership. Only the most specific owners count, because an owned return parameter redefines those of the general types. Owners in the library are left out: the checks do not read the implied specializations to library bases, and without them two library bases look unrelated. The opensysml baselines gain the new finding on `calc c : C1, C2;`, which inherits a return parameter from each type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21.
validateFunctionResultParameterMembershipandvalidateExpressionResultParameterMembershipnow count the returnparameters of the most specific owners in the closure of the type, not only
the owned ones. An owned return parameter redefines those of the general
types, so
function K :> F, H { return t; }stays valid.How to test
Look closely at
specializations, so two library bases look unrelated: checked as user
files, the Systems Library gives 13 false findings in
Requirements.sysml,VerificationCases.sysmlandViews.sysml. As a result,function G :> LibF, H, with a return in a library function and in a userfunction, is still missed. A full fix needs the implied supertypes in the
facts.
probes/validateCalculationUsageType.sysml:calc c : C1, C2;inherits areturn parameter from each type. The corpus findings
(
spec-refs/SysML-v2-Release,apollo-11-sysml-v2) do not change.CHANGELOG.mdentry is under a newUnreleasedheading. Move or dropit as you prefer.