Repository navigation
refactor: remove low-memory desktop mode - #1296
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
appergb
added
branch-retained
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d876d66894
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "format": "prettier --write \"src/**/*.{ts,tsx,css}\" \"android/frontend/**/*.{ts,tsx}\" \"scripts/**/*.{js,mjs,sh}\" \"*.{ts,json,html,sh}\" \"assets/remote-input/*.{js,css,html}\"", | ||
| "format:check": "prettier --check \"src/**/*.{ts,tsx,css}\" \"android/frontend/**/*.{ts,tsx}\" \"scripts/**/*.{js,mjs,sh}\" \"*.{ts,json,html,sh}\" \"assets/remote-input/*.{js,css,html}\"", | ||
| "test:ui-motion": "playwright test", | ||
| "build:native-capsule": "node scripts/build-native-capsule.mjs", | ||
| "build:native-capsule:dev": "node scripts/build-native-capsule.mjs --debug" | ||
| "test:ui-motion": "playwright test" |
There was a problem hiding this comment.
This removes both build:native-capsule scripts, but .github/workflows/ci.yml still runs npm run build:native-capsule:dev in the Tauri and MSRV jobs, so those jobs now fail immediately with an npm “missing script” error. The frontend test suite also still discovers scripts/native-capsule-build.test.mjs, which expects bundle.externalBin to contain the removed helper and will fail against these configs. Update or remove those workflow and contract-test references as part of removing the capsule.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6cde548d7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ); | ||
| } | ||
|
|
||
| // Autostart state is owned by the operating system; it is intentionally not mirrored in prefs. |
There was a problem hiding this comment.
After deleting LowMemoryRuntimeNotice, scripts/native-capsule-health.test.mjs still parses RecordingInputSection.tsx, looks up that function, and asserts that its useEffect exists. The frontend test runner automatically discovers every *.test.mjs under scripts, so npm test now fails at assert.ok(effect, 'execute the production health subscription'); delete or update this test as part of removing the feature.
Useful? React with 👍 / 👎.
| desktop_resources::configure( | ||
| &mut context, | ||
| core_backend.get_preferences().low_memory_background_enabled, | ||
| false, | ||
| ); |
There was a problem hiding this comment.
The runtime is now unconditionally configured with false, so desktop_resources::active() can never enable the native capsule, but both macOS and Windows Tauri configs still run build:native-capsule/build:native-capsule:dev and include binaries/openless-native-capsule as an external binary. Every desktop build therefore continues to require and package an unused sidecar (and can fail on machines lacking its Rust target/toolchain), contrary to this refactor's removal of the low-memory/native-capsule path; remove those hooks and externalBin entries.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89fa0fe8f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| object.remove("lowLatencyDictationEnabled"); | ||
| object.remove("echoCancellationEnabled"); | ||
| object.remove("audioDsp"); | ||
| object.remove("lowMemoryBackgroundEnabled"); | ||
| } |
There was a problem hiding this comment.
For upgraded installations that still have lowMemoryBackgroundEnabled in their persisted preferences, preferences_json_preserving_unknown retains this now-unknown key, but removing it from strip_local_only_preferences allows sync_snapshot to export it as an unregistered preference document. This republishes a device-local setting that the refactor removed; keep stripping or explicitly migrate the legacy key before syncing.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What changed
Remove the low-memory desktop mode as a product capability. The regular desktop window/capsule path is now the only supported path.
Validation
cargo check --locked --manifest-path src-tauri/Cargo.tomlpassed on macOS with a temporary empty frontend dist used only for Tauri config expansion; the temporary directory was removed afterward.git diff --checkpassed.