Skip to content

Add debugger device-settings support to cbuild-run generation#2514

Merged
brondani merged 7 commits into
mainfrom
projmgr-debugger-device-settings
Jul 13, 2026
Merged

Add debugger device-settings support to cbuild-run generation#2514
brondani merged 7 commits into
mainfrom
projmgr-debugger-device-settings

Conversation

@brondani

@brondani brondani commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Added device-settings to debugger parsing, schema validation, context processing, and cbuild-run.yml output.
  • Added fallback extraction of debugger device settings from .dbgconf variable assignments when explicit device-settings are not provided.
  • Added ParseDbgconfFile utility coverage and updated run-debug reference outputs/test data.

Risk / Limitations

  • .dbgconf parsing is limited to simple semicolon-terminated assignments after stripping C-style comments.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@brondani brondani changed the title Add debugger device-settings support to cbuild-run generation Add debugger device-settings support to cbuild-run generation Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

Test Results

  2 files   -    37   14 suites   - 107   14m 42s ⏱️ - 3m 8s
475 tests  -   450  475 ✅  - 433  0 💤  - 17  0 ❌ ±0 
950 runs   - 1 039  950 ✅  - 988  0 💤  - 51  0 ❌ ±0 

Results for commit 03b6dfb. ± Comparison against base commit e8e6d1e.

This pull request removes 451 and adds 1 tests. Note that renamed tests count towards both.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…
ProjMgrUtilsUnitTests ‑ ParseDbgconfFile

♻️ This comment has been updated with latest results.

Comment thread tools/projmgr/src/ProjMgrUtils.cpp Fixed
Comment thread tools/projmgr/src/ProjMgrUtils.cpp Fixed
Comment thread tools/projmgr/src/ProjMgrUtils.cpp Fixed
@brondani brondani requested a review from grasci-arm July 10, 2026 17:11
@brondani

Copy link
Copy Markdown
Collaborator Author

@grasci-arm Please review this PR

@grasci-arm

Copy link
Copy Markdown
Collaborator

Thanks for the ping. I’ll review the PR and get back with comments if I find anything.

@brondani brondani marked this pull request as ready for review July 10, 2026 17:50

@grasci-arm grasci-arm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new device-settings plumbing is broadly coherent, but I found one serious regression risk: dbgconf parsing now silently ignores any final assignment lacking a semicolon and will drop the entire file’s last setting, which can break generated debugger behavior for valid-but-minimal dbgconf content.

@brondani brondani requested a review from edriouk July 10, 2026 18:24
@grasci-arm

Copy link
Copy Markdown
Collaborator

Thanks for the ping — I’ve reviewed the PR and the new device-settings flow looks consistent across parsing, validation, context processing, and cbuild-run.yml generation.

A couple of things stand out as good to keep in mind:

  • the fallback extraction from .dbgconf is limited to simple assignments, so the documented limitation is important
  • the updated tests/reference outputs seem to cover the intended paths well

Overall, the change looks good to me.

@grasci-arm

Copy link
Copy Markdown
Collaborator

Thanks for the ping — I’ll review this PR.

@edriouk edriouk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional unit tests are desirable

Comment thread tools/projmgr/src/ProjMgrUtils.cpp
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.52632% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.35%. Comparing base (e8e6d1e) to head (03b6dfb).

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrUtils.cpp 85.24% 1 Missing and 8 partials ⚠️
tools/projmgr/src/ProjMgrYamlParser.cpp 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2514      +/-   ##
==========================================
+ Coverage   65.29%   65.35%   +0.05%     
==========================================
  Files         147      147              
  Lines       26702    26777      +75     
  Branches    16184    16220      +36     
==========================================
+ Hits        17435    17500      +65     
- Misses       7070     7071       +1     
- Partials     2197     2206       +9     
Flag Coverage Δ
projmgr-cov 87.99% <85.52%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgrParser.h 100.00% <ø> (ø)
tools/projmgr/include/ProjMgrUtils.h 87.50% <ø> (ø)
tools/projmgr/include/ProjMgrWorker.h 83.87% <ø> (ø)
tools/projmgr/src/ProjMgrCbuildRun.cpp 95.70% <100.00%> (+0.06%) ⬆️
tools/projmgr/src/ProjMgrRunDebug.cpp 87.67% <100.00%> (+0.10%) ⬆️
tools/projmgr/src/ProjMgrWorker.cpp 87.53% <100.00%> (+0.02%) ⬆️
tools/projmgr/src/ProjMgrYamlParser.cpp 84.91% <66.66%> (-0.15%) ⬇️
tools/projmgr/src/ProjMgrUtils.cpp 92.20% <85.24%> (-1.43%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brondani brondani requested a review from edriouk July 13, 2026 10:50

@edriouk edriouk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit 9710f8a into main Jul 13, 2026
30 checks passed
@brondani brondani deleted the projmgr-debugger-device-settings branch July 13, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants