Make fpp_uninstall.sh actually clean up plugin artifacts

[pgianotto]

What

Replaces scripts/fpp_uninstall.sh (which only printed messages) with an idempotent cleanup that reverses the side effects this plugin creates outside its plugin directory, as required by the FPP plugin guidelines.

Fixes #11.

fpp_uninstall.sh now does

• Stops mqtt_listener.py — it is started in postStart.sh, but FPP does not run preStop.sh on uninstall, so it would otherwise keep running against a deleted script until the next fppd stop/reboot.
• Removes the SQLite database plugin.fpp-plugin-AdvancedStats.db plus its -journal/-wal/-shm sidecars.
• Removes plugin.fpp-plugin-AdvancedStats.db.backup-* copies left in config/ by the restore and empty-database actions.
• Removes the plugin log file (both the current fpp-plugin-AdvancedStats.log and the guideline-compliant plugin-fpp-plugin-AdvancedStats.log name).
• Removes the plugin settings file config/plugin.fpp-plugin-AdvancedStats.

All removals use rm -f or are guarded, so the script is safe to run more than once. python3-paho-mqtt is intentionally left installed as a shared dependency.

Process match tightened (2nd commit)

pkill/pgrep -f "mqtt_listener.py" is scoped so it can only match this plugin's process:

• postStart.sh — matches the absolute launch path ($MQTT_LISTENER)
• preStop.sh / fpp_uninstall.sh — match fpp-plugin-AdvancedStats/mqtt_listener.py

This does not affect FPP's built-in MQTT (compiled into fppd) or the mosquitto broker service — neither has mqtt_listener.py in its command line.

Out of scope

• Renaming the log file to the plugin-<repoName>.log pattern (so FPP rotates it) touches the Python and PHP writers — noted in fpp_uninstall.sh removes nothing; plugin data/log/DB and running listener left behind #11.
• Moving plugin data from config/ to plugindata/.

Testing

sh -n passes on all three scripts. Paths reviewed against init_database.php, api.php, functions.inc.php, mqtt_listener.py, callbacks.py, and the scripts/ hooks.

🤖 Generated with Claude Code