ci: quote if expression in tag-on-release-merge workflow#429
Merged
Conversation
The unquoted if value contained 'chore: Release ', whose embedded colon-space was parsed as a YAML mapping separator, invalidating the entire workflow file so it never ran. As a result release commits were not auto-tagged and the WordPress.org SVN publish never triggered. Quoting the expression makes it a valid YAML scalar; GitHub Actions still evaluates if strings as expressions.
sherwinski
force-pushed
the
fix/tag-on-release-merge-yaml-quoting
branch
from
e89df16 to
2fb789b
Compare
sherwinski
changed the title
fadi-george
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One Line Summary
Fix invalid YAML in
tag-on-release-merge.ymlthat prevented release commits from being auto-tagged (and therefore published).Motivation
The
if:condition on thetagjob was an unquoted YAML scalar containing'chore: Release '. The embedded:(colon-space) was parsed as a YAML mapping separator, producingmapping values are not allowed in this context at line 15. A YAML syntax error invalidates the entire workflow file, so GitHub refused to load it and the workflow never ran.Impact: when
chore: Release X.Y.Zcommits merged tomain, novX.Y.Ztag was created, so the downstreampublish-svn.yml(triggered onv3.*tags) never fired and the release was not published to WordPress.org. This is what happened with3.9.1(#428) — the tag was missing and had to be pushed manually to unblock the release.Scope
if:line in.github/workflows/tag-on-release-merge.yml.if:strings as expressions, so quoting is purely a YAML-parsing fix.v2releases, which this also fixes.Testing
mapping values are not allowed in this context at line 15 column 60).Checklist