feat: notification show feedback#417
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
…subscriptions and handle non-string API errors
…ent in API integration tests
Contributor
|
Thanks @marclucraft! Will take a look and test this sometime tomorrow or the next day. |
Contributor
Author
|
Hey @sherwinski! Bumping this one 🤜🏼 🤛🏼 |
sherwinski
requested changes
May 6, 2026
sherwinski
left a comment
sherwinski
left a comment
Contributor
There was a problem hiding this comment.
Looks good so far @marclucraft. Could we also add some tests before merging? At minimum a test per status branch verifying which $status/$detail should be stored.
sherwinski
reviewed
May 6, 2026
sherwinski
reviewed
May 6, 2026
sherwinski
reviewed
May 6, 2026
sherwinski
reviewed
May 6, 2026
…ame $detail, let/isSavingMetaBoxes in JS, status-branch tests
Contributor
|
Going to test this out locally before merging |
sherwinski
approved these changes
May 13, 2026
sherwinski
left a comment
sherwinski
left a comment
Contributor
There was a problem hiding this comment.
LGTM and great addition, thanks @marclucraft!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Success / Error notice in Post editor screen for a Notification send.
Related intercom:
https://app.intercom.com/a/inbox/344a89aeac3f033e4dec4370781543b948aece6d/inbox/admin/5709101/conversation/215473037560885?view=List