Skip to content

chore: [SDK-4774] add Unity no-location demo#879

Merged
fadi-george merged 2 commits into
mainfrom
fadi/sdk-4774-no-location-demo
Jul 2, 2026
Merged

chore: [SDK-4774] add Unity no-location demo#879
fadi-george merged 2 commits into
mainfrom
fadi/sdk-4774-no-location-demo

Conversation

@fadi-george

Copy link
Copy Markdown
Collaborator

Description

One Line Summary

Adds a runnable Unity demo that validates OneSignal without the native location module.

Details

Motivation

The Unity SDK needs a dedicated example for apps that exclude the native location module, matching the no-location demos in sibling SDKs and giving reviewers/users a concrete validation path for the opt-out plumbing introduced in the parent PR.

Scope

  • Adds examples/demo-no-location with its own scene, scripts, project settings, package manifest, and README.
  • Exports ONESIGNAL_DISABLE_LOCATION=true from the demo run scripts so CLI builds resolve granular native dependencies.
  • Adds Android Gradle templates/proguard rules and iOS build scripting for the no-location dependency set.
  • Adds link.xml for IL2CPP managed stripping, .env.example, app ID injection during scripted builds, and a test notification button.
  • Updates generated dependency provenance comments to point at the per-project manifest location.

Testing

Unit testing

Not added; this PR is a Unity demo project and build-script addition.

Manual testing

  • Verified as part of the original SDK-4774 branch before splitting:
    • examples/demo-no-location/run-ios.sh --no-install generated granular pods without OneSignalLocation.
    • xcodebuild for the no-location iOS simulator build completed with EXIT=0 and no OneSignalLocation.framework linked.
    • examples/demo-no-location/run-android.sh --no-install built the APK with granular Android dependencies (core, notifications, in-app-messages).
    • ./run-all.sh --sdk=unity --platform=ios passed with 34 tests for the main demo path.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

Made with Cursor

@fadi-george fadi-george requested review from nan-li and sherwinski June 30, 2026 22:03
Base automatically changed from fadi/sdk-4774-location-opt-out to main July 2, 2026 00:00
@fadi-george fadi-george changed the title feat: [SDK-4774] add Unity no-location demo chor: [SDK-4774] add Unity no-location demo Jul 2, 2026
@fadi-george fadi-george changed the title chor: [SDK-4774] add Unity no-location demo chore: [SDK-4774] add Unity no-location demo Jul 2, 2026
fadi-george and others added 2 commits July 1, 2026 17:01
Add a dedicated Unity demo project that exercises the location-module opt-out with no-location native dependencies, scripts, docs, and validation UI.

Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the stacked no-location demo branch aligned with the original SDK-4774 branch's generated Unity project metadata.

Co-authored-by: Cursor <cursoragent@cursor.com>
@fadi-george fadi-george force-pushed the fadi/sdk-4774-no-location-demo branch from f1ca9e9 to 1310c90 Compare July 2, 2026 00:01
@fadi-george fadi-george merged commit 3bc5b42 into main Jul 2, 2026
3 checks passed
@fadi-george fadi-george deleted the fadi/sdk-4774-no-location-demo branch July 2, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants