Skip to content

[Snyk] Security upgrade requests from 2.31.0 to 2.33.0 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
revan-zhang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade requests from 2.31.0 to 2.33.0 #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/requirements-optional.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ web3 >= 4.8
Pillow
stellar-sdk>=4.0.0,<6.0.0
rlp>=1.1.0 ; python_version<'3.7'
requests>=2.33.0 # not directly required, pinned by Snyk to avoid a vulnerability

@cursor cursor Bot Mar 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requests 2.33.0 requires Python 3.10+, breaking older versions

High Severity

The pinned requests>=2.33.0 requires Python 3.10+, but this project supports Python 3.6+ (per setup.py's python_requires=">=3.6"). The tox configuration runs full environments (which install requirements-optional.txt) on py36 through py39. On those Python versions, pip will fail to find any requests version satisfying >=2.33.0, breaking dependency resolution and the CI test matrix for four out of five tested Python versions. A python_version environment marker is needed to restrict this constraint to Python 3.10+.

Fix in Cursor Fix in Web

@cursor cursor Bot Mar 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security fix applied to wrong file, ineffective for users

Medium Severity

The requests security pin is placed in requirements-optional.txt, but requests>=2.4.0 is already a direct dependency in requirements.txt (which feeds install_requires in setup.py). The requirements-optional.txt file is only consumed by the full tox test variant — it has no effect on end-user package installations. Users installing via pip install trezor or pip install -r requirements.txt will still resolve to potentially vulnerable requests versions. The vulnerability fix is effectively a no-op.

Fix in Cursor Fix in Web

Loading