Fix realtime indicator animation not restarting on view recycling#1550
Open
akimovpro wants to merge 1 commit into
Open
Fix realtime indicator animation not restarting on view recycling#1550akimovpro wants to merge 1 commit into
akimovpro wants to merge 1 commit into
Conversation
Restart animation when view becomes visible again after being recycled by the list adapter. Clear old animations before starting new ones to prevent stacking. Fixes OneBusAway#818
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restart animation when view becomes visible again after being recycled by the list adapter. Clear old animations before starting new ones to prevent stacking.
Fixes #818
Changes
onVisibilityChanged()inRealtimeIndicatorViewto restart animation when view becomesVISIBLEand stop it when hiddenclearAnimation()at the start ofinitAnimation()to prevent animation stacking on recycled viewsTest plan
AndroidStyle.xmlstyle template to your code in Android Studio.gradlew connectedObaGoogleDebugAndroidTestto make sure you didn't break anything