Convert MathUtils from Java to Kotlin#1546
Open
al3j4ndrolm wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the ongoing Java → Kotlin modernization effort.
MathUtilsis a pure arithmetic/geometry utility class with no Android dependencies, making it a clean, low-risk starting point for the migration.Changes:
public classwithobject(Kotlin singleton pattern)private static final int→const valtoDirection()negative-check simplified to anifexpression@JvmStaticon all methods to preserve existing Java call sites (VehicleOverlay.java,ArrowView.java,OrientationHelper.java) without modificationRelated issues: N/A
AndroidStyle.xmlstyle template to your code in Android Studio.gradlew connectedObaGoogleDebugAndroidTestto make sure you didn't break anything