Fix #1537 (Item 4): Add accessibility support for arrival badges#1544
Open
Gitkbc wants to merge 1 commit into
Open
Fix #1537 (Item 4): Add accessibility support for arrival badges#1544Gitkbc wants to merge 1 commit into
Gitkbc wants to merge 1 commit into
Conversation
Author
|
@aaronbrethorst Sir, While testing this, I noticed that when a stop has multiple arrivals for the same route, TalkBack reads "Route 128, arriving in 8 minutes" then "Route 128, arriving in 33 minutes" — the repeated route name feels a bit redundant both visually and for screen reader users. Would it be worth showing the route name once and labeling subsequent badges as "Bus 1", "Bus 2"? Also the TalkBack will be "Arriving: Route 128, Bus 1 in 6 minutes, followed by Bus 2 in 33 minutes." I've attached a quick hand-sketch of what I mean. If this sounds like a good enhancement, I’m happy to present a digital preview so we can see exactly how it looks before coding it. Happy to explore this as a follow-up if it sounds useful.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I've implemented the accessibility issues for arrival badges (Item 4 of #1537).
Instead of TalkBack just reading out the tiny badge text, I updated the StarredStopsAdapter to generate a full sentence description—something like "Route 10, arriving in 5 minutes." I also silenced the HorizontalScrollView container so the screen reader doesn't get stuck on it, making it much smoother to swipe through the actual arrival times.
Tested with TalkBack on a physical device — before the fix it read "list", after the fix it correctly announces each badge.