Conversation
✨ [OMF-337] 열려있는 설문 수 및 최고 참여 보상 코인 조회 API 추가
- DefaultSurveyRefundPolicy: 환불 금액 계산 로직 8개 케이스 - QuestionConverter: DTO↔Entity 변환 로직 전 문항 타입 커버 (10개) - SurveyExportService: CSV 빌딩 로직 13개 케이스 (권한, BOM, 이스케이프 등) - DiscountCodeCommandService: 할인 코드 생성 및 중복 재시도 6개 케이스
- MemberTest: 코인 증감, 포인트, 동의 정책, 온보딩, 상태 변경 등 엔티티 비즈니스 로직 (14개) - MemberQueryServiceTest: 조회, 검색, 위임 로직 (7개) - MemberModifyServiceTest: upsertMember(신규/기존), 프로필, 온보딩, 삭제 (9개)
✨ OMF-336 설문 기본정보 조회 시 섹션 개수 반환하도록 수정
DiscountCodeQueryService / SurveyQueryService / SurveyCommandService SurveyGlobalStatsService / ResponseQueryService — 총 36개 테스트
✨ [OMF-338] 단위 테스트 추가 - 순수 비즈니스 로직 (PR 1/3)
✨ [OMF-339] 단위 테스트 추가 - Member 도메인 (PR 2/3)
✨ [OMF-340] 단위 테스트 추가 - 잔여 서비스 레이어 전체 (PR 3/3)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (23)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Related Issue
📌 Task Details
💬 Review Requirements (Optional)