Document the certificate request-attributes epic - #332
Closed
ivosh wants to merge 3 commits into
Closed
Conversation
Documents the request-attributes feature end to end across concept, settings, quick-start, protocol, and contributor pages: - Request Attribute concept page and platform-level Request Attributes settings; RA Profile request-attribute authoring and external-CSR validation (#310). - Custom certificate extensions in the OID registry: OID categories, the Certificate Extension category (Default Critical, Value Encoding incl. the BitString limitation), and the system OID listing (#311). - Platform-key issuance and certificate pre-registration: the Add Certificate form, the register-certificate quick start, the Pending Registration and Registered states, the Certificate registered event, and registration platform defaults (#312). - Authority Provider v3, the structured requestContent wire contract, and the fieldMapping/valueSource attribute model (#313). - Request-attribute validation semantics and per-protocol error mapping for ACME, CMP, and SCEP (#314). Closes #309 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Documents the “certificate request-attributes” epic end-to-end across operator, protocol, connector, and contributor documentation for the ILM Docusaurus site.
Changes:
- Adds request-attribute concept and platform/RA-profile authoring + external-CSR validation documentation.
- Adds pre-registration (“register certificate”) quick start and updates related platform defaults, state model, and workflow event docs.
- Adds connector-facing Authority Provider v3 and structured
requestContentwire contract documentation, plus protocol-level validation semantics.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/contributors/attributes/request-attributes.mdx | New contributor-facing model/reference doc for fieldMapping and valueSource. |
| docs/certificate-key/settings/request-attributes.md | New platform settings page for default request-attribute set + external CSR validation default. |
| docs/certificate-key/settings/platform.md | Adds platform “Registration” defaults section and links to the preregistration quick start. |
| docs/certificate-key/settings/oid.md | Documents OID categories and custom certificate extension OID behavior/encoding rules. |
| docs/certificate-key/quick-start/certificate-management/register-certificate.mdx | New end-to-end preregistration flow (UI + API) and platform defaults references. |
| docs/certificate-key/quick-start/certificate-management/issue-certificate.mdx | Updates issuance docs to cover “Issue now” vs “Pre-register” and request-attribute/CSR validation behavior. |
| docs/certificate-key/quick-start/certificate-management/create-ra-profile.mdx | Adds RA Profile request-attribute authoring instructions (merge mode, mappings, value sources, bindings). |
| docs/certificate-key/protocols/common-properties.md | Adds shared request-attribute validation semantics and per-protocol error mapping. |
| docs/certificate-key/connectors/provider-interfaces/request-attributes-structured.md | New connector wire-contract doc for structured requestContent and identity override behavior. |
| docs/certificate-key/connectors/provider-interfaces/authority-provider-v3.md | New overview doc for v3 interface and capability flags. |
| docs/certificate-key/concept-design/modules/certificate-management.md | Adds registration operation and integrates request attributes into issuance narrative. |
| docs/certificate-key/concept-design/core-components/workflow/event.md | Adds “Certificate registered” workflow event row. |
| docs/certificate-key/concept-design/core-components/request-attribute.md | New core concept doc: mapping targets, sources, resolution algorithm, and usage sites. |
| docs/certificate-key/concept-design/core-components/ra-profile.md | Adds request-attributes resolution and external CSR validation mode documentation. |
| docs/certificate-key/concept-design/core-components/certificate.md | Updates certificate state model/diagram for preregistration states and authorization state note. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot: - Fix subject/verb agreement in issue-certificate intro (represent/of) - Remove double slash in commented placeholder URL (operations/authorities) - Match certificate state label casing (Pending Registration) - Add missing /api prefix to the completion-endpoint snippet Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…attribute docs - Authority Provider v3 is now the full standalone page: process sections and sequence diagrams (connector-side operation links omitted until the v3 OpenAPI spec is published), a new Register flow, and asynchronous operation semantics tied to the capability flags. - Authority Provider v2 slims down to an overview that defers to v3 for the shared processes, with a compared-to-v3 delta list. Inbound links now point to v3 as the current interface. - One canonical home per explanation: set resolution lives on the Request Attribute concept page, validation checks on the RA Profile page; other pages link instead of restating. - Drop the operator-facing "Value provenance" section (the authoring UI has no such control); trim the SAN type enumeration on the concept page. - Renumber provider-interface sidebar positions to whole numbers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was
linked to
issues
Jul 30, 2026
Open
Collaborator
|
This is replaced by #340 - the PR is built from this one. |
This was
unlinked from
issues
Jul 30, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the certificate request-attributes epic end to end — one page set spanning concept, settings, quick starts, protocols, and contributor docs.
What this adds
requestContentwire contract, and thefieldMapping/valueSourceattribute model.Notes
🤖 Generated with Claude Code