Repository navigation
fix: date pickers open on the minimum date when it changes while the value is empty - #16
Merged
Merged
Conversation
…value is empty The picker state was keyed on the value only, so an end-date field created before its start date was picked kept opening on today. Key it on the fallback date as well.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An end-date picker created with an empty value and no minimum kept opening on today after the start date was picked, because the picker state was keyed on the value only. It is now keyed on the fallback date too, in both
FormInputDatePickerFieldandFormInputDateTimePickerField.Tests:
PickerOpensOnMinDateTest(both fields) failed before the change and passes now;:forminput:jvmTestis green.