Skip to content

fix(cooler): refresh loans docs for current contracts - #229

Open
zeroxzerollc wants to merge 2 commits into
OlympusDAO:mainfrom
zeroxzerollc:fix/cooler-loans-current-contracts
Open

fix(cooler): refresh loans docs for current contracts#229
zeroxzerollc wants to merge 2 commits into
OlympusDAO:mainfrom
zeroxzerollc:fix/cooler-loans-current-contracts

Conversation

@zeroxzerollc

@zeroxzerollc zeroxzerollc commented May 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • demotes Cooler V2 Migrator out of the current architecture and primary contracts table into legacy migration support
  • removes stale hardcoded LTV/example values from the Cooler Loans overview and points users to the live LTV Oracle/app values instead
  • clarifies that Cooler V2 has no external price-oracle liquidation, while debt can still default if it crosses the protocol-defined threshold
  • tightens delegation wording so DLGTE is described as voting-power delegation, not shared loan management
  • adds legacy V1 Clearinghouse addresses separately from current Cooler V2 contracts

Verification

  • pnpm exec prettier --check docs/overview/04_cooler-loans.md
  • git diff --check
  • pnpm build succeeds; repo has pre-existing broken-link warnings unrelated to this page

Notes

Current Cooler V2 contract addresses were checked against the existing docs/contract references and Olympus Cooler contract registry notes. The Migrator is intentionally kept only in the legacy contracts table so the docs do not present it as part of the normal/current borrowing surface.

Summary by CodeRabbit

  • Documentation
    • Updated Cooler Loans overview to align with Cooler V2 specifications
    • Clarified loan terms, conditions, and added new repayment examples
    • Added information on legacy position migration
    • Expanded FAQ with additional details on repayment mechanics
    • Corrected terminology throughout

@vercel

vercel Bot commented May 8, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Olympus Association Team on Vercel.

A member of the Team first needs to authorize it.

@zeroxzerollc

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@brightiron has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 17 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7fda5c3b-8971-44de-9037-6f3c535b637a

📥 Commits

Reviewing files that changed from the base of the PR and between 0d5fdab and 5d88050.

📒 Files selected for processing (1)
  • docs/overview/04_cooler-loans.md

Walkthrough

This PR updates the Cooler Loans documentation to align with Cooler V2 mechanics and governance. Changes clarify oracle-backed LTVs, replace V1-specific language, refine loan and repayment examples, add legacy migration guidance, and correct typos in the FAQ.

Changes

Cooler Loans V2 Documentation Alignment

Layer / File(s) Summary
Terminology & Assumptions
docs/overview/04_cooler-loans.md
"Delegated Multi-Wallet Access" and "Oracle-Free" replaced with "Delegated Voting Power" and "No External Price Oracle, Fully Treasury-Backed".
Loan Terms & Parameters
docs/overview/04_cooler-loans.md
New "Loan Terms and Conditions" section updated to reference CoolerV2LtvOracle for current LTVs; removed obsolete Clearinghouse/V1 LTV targets and drip-cadence details.
Borrowing & Repayment Workflows
docs/overview/04_cooler-loans.md
Loan opening example now emphasizes LTV-determined maximum borrow and immediate interest accrual; new repayment example shows scenario-driven outcomes for interest-only, exact interest, excess-over-interest, and fully-repaid cases.
Governance & Delegation
docs/overview/04_cooler-loans.md
"End State" delegation wording updated from multi-wallet access to governance participation delegation across up to 10 addresses.
Legacy Migration & Support
docs/overview/04_cooler-loans.md
Added "Legacy V1 Migration Support" section describing V1 position consolidation via Olympus app; added "Legacy Contracts" table listing Clearinghouse contracts and Cooler V2 Migrator.
Summary & FAQ Clarifications
docs/overview/04_cooler-loans.md
Removed liquidation risk elimination claim from Summary; corrected FAQ typo ("interst" → "interest") and clarified that full interest payment is required to recover principal.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Cooler V2 takes the stage so bright,
With oracle-backed LTVs and governance might,
V1 migrations find their gentle way,
Loan flows and FAQs refreshed today!
Treasury-backed and forever to stay! 🌱

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: updating/refreshing Cooler loans documentation to reflect current contracts and removing outdated V1/Clearinghouse references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/overview/04_cooler-loans.md`:
- Line 155: The sentence "Interest is charged on an accrual basis. To get your
principal back you will need to pay interest in full." is confusing—replace it
with wording that clarifies borrowers repay the debt (principal) and that
collateral becomes releasable once accrued interest and any outstanding amounts
are paid; update the sentence in the docs (the line containing "To get your
principal back you will need to pay interest in full.") to something like:
"Interest accrues on the loan; you must pay the accrued interest (and any
outstanding principal) in full to satisfy the debt and have your collateral
released." Ensure the new sentence replaces the original exact line.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c6da28a4-0e71-46de-8793-2929a2622392

📥 Commits

Reviewing files that changed from the base of the PR and between d34d131 and 0d5fdab.

📒 Files selected for processing (1)
  • docs/overview/04_cooler-loans.md

Comment thread docs/overview/04_cooler-loans.md Outdated
@zeroxzerollc
zeroxzerollc force-pushed the fix/cooler-loans-current-contracts branch 9 times, most recently from 6ca647e to f85023f Compare May 8, 2026 22:14
@zeroxzerollc
zeroxzerollc force-pushed the fix/cooler-loans-current-contracts branch from f85023f to 0977da7 Compare May 8, 2026 22:20
@brightiron
brightiron marked this pull request as ready for review May 14, 2026 02:37
@vercel

vercel Bot commented May 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
olympus-docs Ready Ready Preview, Comment May 14, 2026 2:41am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant