[excel] (Range) Merge precedent and dependent samples#1090
Open
AlexJerabek wants to merge 2 commits into
Open
Conversation
davidchesnut
approved these changes
May 13, 2026
Member
davidchesnut
left a comment
davidchesnut
left a comment
There was a problem hiding this comment.
One suggestion added. Also wondering if it should show an error when you select a cell without dependents or precedents? Or should it show something like "none" in the console.
Otherwise I like the combining!
Collaborator
Author
Thanks @davidchesnut! That's a good idea - I'll add it. |
Collaborator
Author
|
@davidchesnut, so it turns out the precedent/dependent APIs throw errors by design when they have no precedents or dependents. There's not really an empty check that wouldn't overcomplicate the sample. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three snippets about this topic were very similar. This PR merge them into a single snippet for better discoverability.
This PR also updates the tsconfig files to avoid some VSCode warnings.