[excel] (Shapes) Add shape fill and line format samples#1087
Merged
Conversation
AlexJerabek
requested review from
ElizabethSamuel-MSFT
and removed request for
davidchesnut
| await context.sync(); | ||
| }); | ||
| Excel.Shape#fill:member: | ||
| Excel.Shape#fill:member(1): |
Contributor
There was a problem hiding this comment.
This is a Shape.fill is a property not a method
Suggested change
| Excel.Shape#fill:member(1): | |
| Excel.Shape#fill:member: |
| textbox.name = "Textbox"; | ||
| await context.sync(); | ||
| }); | ||
| Excel.ShapeFill#setSolidColor:member(1): |
Contributor
There was a problem hiding this comment.
Consider including a mapping for Excel.ShapeFill class
Co-authored-by: Elizabeth Samuel <elizs@microsoft.com>
Collaborator
Author
|
Thanks @ElizabethSamuel-MSFT! Feedback heard and applied. |
| textbox.name = "Textbox"; | ||
| await context.sync(); | ||
| }); | ||
| Excel.ShapeFill:interface: |
Contributor
There was a problem hiding this comment.
ShapeFill is a class
Suggested change
| Excel.ShapeFill:interface: | |
| Excel.ShapeFill:class: |
Collaborator
Author
There was a problem hiding this comment.
Why is this randomly a class...
Contributor
There was a problem hiding this comment.
ShapeFill for PPT and Word are also classes...
Collaborator
Author
There was a problem hiding this comment.
True, but I find the object model distinction between class and interface arbitrary, especially since everything in Scripts is an interface.
ElizabethSamuel-MSFT
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a Script Lab sample to cover a bunch of shape APIs that don't otherwise have coverage.