Conversation
james-prysm
reviewed
Sep 18, 2026
|
|
||
| // Check punycode: host must be ASCII. | ||
| if strings.IndexFunc(host, func(r rune) bool { return r > unicode.MaxASCII }) >= 0 { | ||
| return errors.New("url hostname must be ASCII; encode internationalized names as punycode") |
Contributor
There was a problem hiding this comment.
should it include the url?
james-prysm
reviewed
Sep 18, 2026
| // groups g1..g5=0 g6=ffff g7 g8 | ||
| // | ||
| // so 192.0.2.1 (c0 00 02 01) gives g7=0xc000, g8=0x0201 -> "::ffff:c000:201". | ||
| b := addr.As16() |
Contributor
There was a problem hiding this comment.
should this be some kind of helper?
Member
Author
There was a problem hiding this comment.
Maybe not, I'm not sure whether we will use this logic in other places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Implements this spec change.
Which issue(s) does this PR fix?
N/A
Other notes for review
Note that using the current version of buildoor would probably have some trouble as buildoor is not yet updated (Nico already opened a PR for this). So I'd suggest to merge this PR after all open PRs are merged.
Acknowledgements