Fix bug in extracting L2 msgs from batch and enable skipped system_tests

[ganeshvanahalli]

This PR enables those system_tests which were skipped previously because of pending bugs resolution in MEL and it also solves an issue where L2 message extraction from batch segment didn't match the flow currently seen in inboxMultiplexer used by inbox-tracker code.

Now only the system_tests relating to validation will be skipped when MEL is enabled

Resolves NIT-3883

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 34.41%. Comparing base (192393a) to head (9bcf38a).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4551      +/-   ##
==========================================
+ Coverage   34.20%   34.41%   +0.20%     
==========================================
  Files         494      494              
  Lines       58926    58929       +3     
==========================================
+ Hits        20156    20279     +123     
+ Misses      35230    35065     -165     
- Partials     3540     3585      +45     

[github-actions]

❌ 19 Tests Failed:

Tests completed	Failed	Passed	Skipped
4716	19	4697	0

View the top 3 failed tests by shortest run time

TestAliasingFlaky

Stack Traces | -0.000s run time

=== RUN   TestAliasingFlaky
=== PAUSE TestAliasingFlaky
=== CONT  TestAliasingFlaky
    common_test.go:787: BuildL1 deployConfig: DeployBold=true, DeployReferenceDAContracts=false
INFO [04-02|22:41:58.950] New local node record                    seq=1,775,169,718,949 id=e620d07b7cbf6fba                        ip=127.0.0.1 udp=0 tcp=0
INFO [04-02|22:41:58.950] Started P2P networking                   self=enode://a7d4b10f25eadda0d0d42f03ec47fbd9c9bbfbfdbd5596303c61e4ed2f628f36bd074e0b19f912474c0d10470eb01639877aede0af92ba8d4ed507cdfd330dd0@127.0.0.1:0
WARN [04-02|22:41:58.950] Getting file info                        dir= error="stat : no such file or directory"
INFO [04-02|22:41:58.950] Started log indexer

TestBatchPosterL1SurplusMatchesBatchGasFlaky

Stack Traces | 0.550s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
panic: runtime error: invalid memory address or nil pointer dereference [recovered, repanicked]
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x207ea12]

goroutine 58 [running]:
testing.tRunner.func1.2({0x37e7160, 0x62029b0})
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1872 +0x237
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1875 +0x35b
panic({0x37e7160?, 0x62029b0?})
	/opt/hostedtoolcache/go/1.25.8/x64/src/runtime/panic.go:783 +0x132
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).GetBatchCount(0x6f900?)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:210 +0x12
github.com/offchainlabs/nitro/arbnode.(*InboxTracker).FindInboxBatchContainingMessage(0x0, 0x6)
	/home/runner/work/nitro/nitro/arbnode/inbox_tracker.go:225 +0x2f
github.com/offchainlabs/nitro/system_tests.TestBatchPosterL1SurplusMatchesBatchGasFlaky(0xc0004836c0)
	/home/runner/work/nitro/nitro/system_tests/batch_poster_test.go:839 +0x725
testing.tRunner(0xc0004836c0, 0x41b9e88)
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1997 +0x465

TestRedisProduceComplex/one_producer,_all_consumers_are_active

Stack Traces | 1.240s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
�[36mDEBUG�[0m[04-02|22:37:47.065] consumer: xack                           �[36mcid�[0m=2fbde74b-ebc1-42a5-a98f-d1d661ad54c2 �[36mmessageId�[0m=1775169465973-13
�[36mDEBUG�[0m[04-02|22:37:47.065] consumer: xdel                           �[36mcid�[0m=2fbde74b-ebc1-42a5-a98f-d1d661ad54c2 �[36mmessageId�[0m=1775169465973-13
�[33mWARN �[0m[04-02|22:37:47.065] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1775169465973-12
�[33mWARN �[0m[04-02|22:37:47.066] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1775169465973-11
�[33mWARN �[0m[04-02|22:37:47.066] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1775169465939-2
�[36mDEBUG�[0m[04-02|22:37:47.066] consumer: xdel                           �[36mcid�[0m=3048c384-82af-45d4-8b35-21d94fecfcf6 �[36mmessageId�[0m=1775169465972-3
�[33mWARN �[0m[04-02|22:37:47.066] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1775169465973-3
�[33mWARN �[0m[04-02|22:37:47.066] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1775169465973-7
�[33mWARN �[0m[04-02|22:37:47.066] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1775169465973-1
�[33mWARN �[0m[04-02|22:37:47.066] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1775169465973-4
�[33mWARN �[0m[04-02|22:37:47.066] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1775169465973-6
�[33mWARN �[0m[04-02|22:37:47.066] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1775169465974-1
�[33mWARN �[0m[04-02|22:37:47.066] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1775169465974-0
�[33mWARN �[0m[04-02|22:37:47.066] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1775169465973-2
�[36mDEBUG�[0m[04-02|22:37:47.068] checkResponses                           �[36mresponded�[0m=36 �[36merrored�[0m=0 �[36mchecked�[0m=98
�[36mDEBUG�[0m[04-02|22:37:47.074] redis producer: check responses starting
�[31mERROR�[0m[04-02|22:37:47.116] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpendingLen�[0m=0
�[36mDEBUG�[0m[04-02|22:37:47.117] checkResponses                           �[36mresponded�[0m=62 �[36merrored�[0m=0 �[36mchecked�[0m=62
�[36mDEBUG�[0m[04-02|22:37:47.172] Error destroying a stream group          �[36merror�[0m="dial tcp 127.0.0.1:34971: connect: connection refused"
--- FAIL: TestRedisProduceComplex/one_producer,_all_consumers_are_active (1.24s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[gligneul]

@ganeshvanahalli looks good! Please take a look at the CI job. It seems there is a linter error.

[eljobe]

I have retried the defaults-B test a couple of times on this branch. Are you sure its failure is not related to this change?
@ganeshvanahalli

[ganeshvanahalli]

I have retried the defaults-B test a couple of times on this branch. Are you sure its failure is not related to this change? @ganeshvanahalli

@eljobe CI doesn't fail anymore and the tests pass locally for me too

[joshuacolvin0]

This PR is flaky. Using copilot or Claude will help you narrow down reasons for failures and help you fix issues with this test