fix(collection): drop computed defaults from argument specs - #191
Conversation
…on must not depend on gathered facts
|
Warning Review limit reached
Next review available in: 30 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… without gathered facts
|
Extended with a second commit: the same class of failure exists one layer deeper. Argument-spec validation type-checks the current value of declared options, so a role default that templates from facts ( |
Two argument-spec options carried templated defaults that reference gathered facts or another role's vars (
elasticsearch_heapfromansible_facts.memtotal_mb,kibana_server_publicbaseurlfromelasticstack_kibana_host/ansible_facts.fqdn). Spec defaults are evaluated at validation time even when the option is not supplied, and the validation task is taggedalways— so any tag-limited run where fact gathering is skipped (smart gathering with a warm cache) fails withobject of type 'dict' has no attribute 'memtotal_mb'before a single real task runs. Hit in production on a--tagsrun the day after #184 landed.The real defaults live in
defaults/main.ymland are unaffected; the spec entries keep their descriptions and lose only the computeddefault:.