refactor(elasticsearch): replace no-op loop-over-group in upgrade includes with a membership guard

[Oddly]

Both rolling-upgrade includes in main.yml looped over the whole elasticsearch group with hostvars[item].inventory_hostname == inventory_hostname, which only ever matches the host itself: the loop ran the include at most once and produced one skip line per other group member per host (98 skip lines on a 7-node cluster), suggesting per-group behaviour that doesn't exist.

The loop did double as an accidental group-membership check (a loop over an empty/absent group skips the task), so the replacement keeps that explicitly: inventory_hostname in groups[...] | default([]). The default([]) also removes an undefined-variable failure when the group is absent, which the old construct would have hit.

Covered in tests/integration/elasticsearch_upgrade_detection_contract.yml; fails if either the loop returns or the membership guard is dropped.

[coderabbitai]

Warning

Review limit reached

@Oddly, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b656a5fe-e302-4738-9a02-ec5be0bf4c5b

📥 Commits

Reviewing files that changed from the base of the PR and between 05d430c and dd9d55b.

📒 Files selected for processing (1)

• roles/elasticsearch/tasks/main.yml

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}