Commit To Git Step: Skip committing when transformation script fails#2052
Open
tleed5 wants to merge 3 commits into
Open
Commit To Git Step: Skip committing when transformation script fails#2052tleed5 wants to merge 3 commits into
tleed5 wants to merge 3 commits into
Conversation
octonautcal
approved these changes
Jun 30, 2026
APErebus
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit to git step currently will commit any changes made regardless of the success of the transformation script, so a script could partially succeed and make some file changes, those changes will be committed even though the deployment has failed.
This change makes it so that the convention to commit files is skipped if the script exit code != 0, so a deployment failing due to the transformation script won't leave behind artifacts(commits, pull requests etc)
Tested locally against latest version of main
