Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a
nutrientsanddetritusforLOBSTERwhich each have only a single tracerNandDso when activated theLOBSTERmodel only hasNPZD, or the DIC/Alk and/or oxygen can also be turned on.I also added the possibility to turn on temperature dependance in
PhytoZoowith the Q10 parameterisation from the NPZD model (Kuhn 2015) which is turned on by changing the value oftemperature_coefficientto anything other than 1 (and having a temperature tracer).By default when these are activated the P/Z parameterisations are still from the LOBSTER model so it won't be exactly the same as the NPZD model, but its probably just a case of changing parameter values if we wanted to do that. I might remove the
NPZDmodel and replace it with a function that returns this model with the parameters to replicated Kuhn 2015 NPZD.I think this raises the question as to whether we should change the name of
LOBSTERto something more generic (we could have a constructor that returns the LOBSTER configuration) because it now has optionally: variable C:N detritus, these options, and iron limitation, and I think its likely we might develop other nutrient cycles/alkalinity parameterisations/dual carbon chem/variable Chl phytoplankton etc. from this - @johnryantaylorI haven't done any validation or testing beyond checking that it steps yet but wanted to open the discussion about renaming while I worked on it.
CC: @lgloege - you could use this to have NPZD with DIC/Alk