Add configurable z-score severity thresholds - #76
Open
Ochibueze474 wants to merge 2 commits into
Open
Conversation
AnupamKumar-1
self-requested a review
September 8, 2026 01:31
| medium_threshold: float = 2.0, | ||
| high_threshold: float = 3.0 | ||
| ) -> DeviationSeverity: | ||
| abs_z = abs(z_score) |
Member
There was a problem hiding this comment.
Should we validate that low_threshold < medium_threshold < high_threshold here? Without that, an out-of-order configuration can silently produce incorrect severities. A ValueError would make invalid configuration fail loudly; alternatively, documenting this ordering requirement would make the contract explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds configurable severity thresholds as requested in issue #69.
classify_severity() now accepts optional low_threshold, medium_threshold, and high_threshold parameters, defaulting to the original values (1.0, 2.0, 3.0) so nothing changes for existing callers. detect_ml_anomalies() passes these through too, so custom thresholds work end to end.
Added tests for non-default thresholds in both test files, and updated the README table since Python now matches Node here.
While I was in these files, ruff flagged some older-style type hints (List, Optional) that predate this change, so I cleaned those up too since it was a quick fix.
All 85 tests pass, and ruff/pylint are both clean on the files I touched.
Since Node already supports this, I didn't think a follow-up issue was needed for the other SDK, let me know if you'd prefer otherwise.
Fixes #69