Default browser setting#35
Open
nchursin wants to merge 1 commit into
Open
Conversation
Owner
|
Good thought, will review today. Which operating systems have you tested this in? |
Oblongmana
self-requested a review
July 17, 2017 21:29
Author
|
MacOS Sierra. I'll test it on Ubuntu 16 tonight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin opens reference in default system browser (Safari for me). I don't want to use it, I want to use Chrome instead. So I made a
default_browsersetting, where you should specify a path to your browser executable, e.g.:{ "default_browser": "/Applications/Google Chrome.app" }If the setting is empty it will still use the default browser.
I did this stuff for myself, but then realized I may be not the only one. Instead of posting an issue, I figured I might as well post a pull request.