refactor(cmd): reorganize cmd/camp into package-owned command domains

[obey-agent]

Summary

• move the cache, registry, skills, refs, dungeon, intent, navigation, leverage, project, and project/worktree command families into package-owned directories under cmd/camp/
• preserve the deprecated camp worktrees ... compatibility surface while making camp project worktree ... the canonical ownership boundary
• document conditional branch reality for quest and project_remote, and record the final root cleanup assessment instead of forcing a late risky extraction

Validation

• fest validate passed for cmd-camp-package-reorganization-CC0006
• just build stable
• just build dev
• just test unit (1887/1887 tests passed)
• just test integration (123/123 tests passed)
• representative help parity matched baseline for:
  • camp --help
  • camp project --help
  • camp project worktree --help
  • camp worktrees --help
  • camp intent --help
  • camp refs-sync --help
• go vet ./cmd/camp/...
• go list ./cmd/camp/...

Follow-Up

• the original root <20 files target was not met safely; the final root remains 49 .go files (35 non-test, 14 test)
• deferred follow-up packaging work remains for top-level git-ops, file/path utility, and intent intake commands if further root reduction is still desired
• if project_remote or a future dev-only quest family lands later, it should follow the same package-ownership pattern rather than reintroducing flat-package ownership

[obey-agent]

Staff Review — cmd/camp Package Reorganization

Well-executed mechanical refactor. The structural goals are achieved: command families are package-owned, the import graph has no cycles, root registration is explicit and tested, and shared helpers are extracted into a coherent cmdutil layer.

Architecture Assessment

Import graph is clean and acyclic. root.go imports all 11 sub-packages, each sub-package imports only cmdutil and internal/*, cmdutil imports only internal/*, and project/root.go imports project/worktree as the single intentional parent-to-child link.

cmdutil is not a dumping ground. The 5 files are all genuinely cross-cutting CLI-layer helpers. Good restraint.

root_registration_test.go pointer-identity tests are the right enforcement mechanism — catches any case where a command is constructed as a new instance rather than referencing the package's exported Cmd.

Important Issues

1. ctx == nil nil-guards in 3 files — these mask improperly constructed test commands rather than fixing the real issue. cobra.Command.Context() never returns nil in production. See inline comments.

2. cmdutil/config.go: LoadCampaignConfigSafe is a no-op wrapper — it calls config.LoadCampaignConfigFromCwd and returns all three values unchanged. The "Safe" suffix implies graceful error handling but it doesn't add any. Callers can invoke the underlying function directly. See inline.

Medium Issues

3. navigation/shortcuts.go: ShortcutsCmd.GroupID set in init() rather than var declaration — inconsistent with every other package in this PR. See inline.

4. leverage/main_command.go: redundant Cmd.Args assignment — root.go already sets Args: cobra.MaximumNArgs(1), then init() reassigns the same value.

5. Two-phase RunE initialization (root.go sets placeholder, then commands.go/main_command.go overwrite in init()) — technically correct but misleading to readers of root.go alone. Consider declaring RunE: nil in root and setting it only in the command file.

6. worktrees/ deprecation shim duplicates logic with project/worktree/ — accepted trade-off per PR description, but track the removal as a follow-up to prevent the duplication from becoming permanent.

What's Done Well

• internal/nav extraction eliminates buildCategoryMappings duplication between go.go and complete.go
• internal/git/query.go promotes gitOutput to git.Output, deleting both private copies
• pins.MigrateLegacyStore extraction puts migration logic next to the type it operates on
• Deprecation shim for camp worktrees is mechanically sound
• PR honestly documents that <20 files target was not met (49 remain) with sound deferral rationale
• 1887 unit + 123 integration tests all pass

No blocking issues. See inline comments for the items worth addressing.

[obey-agent]

Important: remove ctx == nil guard — fix test setup instead

This pattern appears in 3 files (leverage/main_command.go, navigation/go.go, refs/commands.go):

ctx := cmd.Context()
if ctx == nil {
    ctx = context.Background()
}

cobra.Command.Context() never returns nil when run through cobra — it returns context.Background() by default. The only path to nil is tests that call RunE directly without calling SetContext first.

The fix is in the tests, not the production code:

cmd.SetContext(context.Background())

root_registration_test.go already does this correctly for its handler tests. These guards will mask the fact that tests run without a proper context, which matters once any context-aware timeout or cancellation logic is added.

[obey-agent]

Important: no-op wrapper

This function does nothing beyond calling config.LoadCampaignConfigFromCwd and returning all three values unchanged:

func LoadCampaignConfigSafe(ctx context.Context) (*config.CampaignConfig, string, error) {
    cfg, root, err := config.LoadCampaignConfigFromCwd(ctx)
    if err != nil {
        return nil, "", err
    }
    return cfg, root, nil
}

The "Safe" suffix implies graceful error handling, but it just propagates the error normally. Both callsites (navigation/shortcuts.go and concepts.go) handle the fallback in their own code after the call. Callers can invoke config.LoadCampaignConfigFromCwd directly — removing this wrapper eliminates a layer of indirection and a misleading name.

[obey-agent]

Medium: inconsistent GroupID assignment

Every other exported Cmd in this PR sets GroupID in the var Cmd = &cobra.Command{...} declaration (see cache/root.go, dungeon/root.go, intent/root.go, skills/root.go, worktrees/root.go). ShortcutsCmd sets it here in init() instead.

Move it to the var declaration for consistency:

var ShortcutsCmd = &cobra.Command{
    Use:     "shortcuts",
    GroupID: "navigation",
    ...
}

[obey-agent]

Verification Note

Re-checked the three items from the initial review against the current branch state:

1. ctx == nil nil-guards — not present in the three files flagged (leverage/main_command.go, navigation/go.go, refs/commands.go). All use ctx := cmd.Context() directly.
2. LoadCampaignConfigSafe — does not exist in the codebase. Callers use config.LoadCampaignConfigFromCwd directly.
3. ShortcutsCmd.GroupID — already set inline in the var declaration, not in init().

All three items are resolved. Build, vet, and tests pass. No outstanding issues remain on this PR.

[obey-agent]

Follow-up Review — commit af3156b4

All review items addressed.

1. ctx == nil nil-guards — Removed

Removed from all 3 files. leverage/main_command_test.go updated with root.SetContext(context.Background()) — correct fix in the test rather than guarding in production.

2. LoadCampaignConfigSafe — Deleted

cmdutil/config.go removed entirely. Both callers (concepts.go, shortcuts.go) now call config.LoadCampaignConfigFromCwd directly with updated imports.

3. ShortcutsCmd.GroupID — Moved to var declaration

Now inline at GroupID: "navigation" in the struct literal, matching every other package in this PR.

4. Bonus: redundant Cmd.Args — Removed

Cmd.Args = cobra.MaximumNArgs(1) removed from leverage/main_command.go init() — already declared in root.go.

No outstanding issues. This PR is ready to merge.