refactor: rename injected thought field to toolcall_reason#152
Merged
Conversation
Oaklight
force-pushed
the
feature/toolcall-reason-rename
branch
from
6a4a6b0 to
c2a2088
Compare
Rename the think-augmented tool calling field from `thought` to `toolcall_reason` to eliminate naming collisions with tools that natively declare a `thought` parameter (e.g. ThinkTool). This simplifies the codebase by removing `_has_native_thought_param()` and all its conditional call sites — the unique field name makes collision detection unnecessary. Also includes three admin panel fixes: - Add version info button (GET /api/info) showing library versions - Validate env var requirements before enabling tools/namespaces - Reset toggle state on enable failure
Oaklight
force-pushed
the
feature/toolcall-reason-rename
branch
from
c2a2088 to
3398eb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thoughttotoolcall_reasonto eliminate naming collisions with tools that natively declare athoughtparameter (e.g. ThinkTool). This deletes_has_native_thought_param()and all conditional call sites, simplifying the execution path.GET /api/infoendpoint that returnstoolregistryandtoolregistry_serverversions."Missing env: ..."disable reason and returns 400 if vars are still unset. Also resets the UI toggle on enable failure.Test plan
ruff check+ruff formatclean