Skip to content

fix(ocr): read the completion card on 16:10 and spell 渣客镇 correctly - #52

Merged
Teakowa merged 1 commit into
mainfrom
fix/16-10-settlement-card
Nov 3, 2026
Merged

Teakowa merged 1 commit into
mainfrom
fix/16-10-settlement-card

Conversation

@e54-bot

@e54-bot e54-bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Layout 1280x800-v5 gains the settlement_card ROI; 16:10 screenshots no longer lose map, difficulty, deaths, skips and version.
  • maps.yaml: 渣克镇 → 渣客镇, matching the game and the platform catalog.
  • Compatibility matrix requires the card fixture set on 1280x800-v5; the datasets pointer adds a 16:10 fixture.

Verification

  • pytest: 438 passed. compatibility_gate: ok, no failures.
  • Both reported screenshots recognised correctly locally.

Notes

  • Depends on OWBastion/ocrkit-datasets feat/settlement-card-fixture (draft PR); merge it first.
  • left_panel.hero_progress_missing still appears for the new card; left unchanged pending a decision.

Layout 1280x800-v5 gains the settlement_card ROI, so 16:10 screenshots no longer lose map, difficulty, deaths, skips and version. The map catalog listed 渣克镇, which the platform does not know; the game prints 渣客镇.
@Teakowa
Teakowa marked this pull request as ready for review November 3, 2026 18:02
@Teakowa
Teakowa merged commit 5dde017 into main Nov 3, 2026
2 checks passed
@Teakowa
Teakowa deleted the fix/16-10-settlement-card branch November 3, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants