Repository navigation
feat(parser): report achievement challenge disabled notice - #51
Merged
Merged
Conversation
Read the 成就挑战已禁用 notice from the left panel and expose it as the additive achievement_challenge_disabled evidence field. It is null when the notice is not read.
The titles line of the settlement card can carry the notice. Report it as achievement_challenge_disabled and keep it out of the title candidates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
achievement_challenge_disabled. It istruewhen the game's成就挑战已禁用notice is read from the left panel or from the titles line of the settlement card. Otherwise it isnull, so a missing notice is not proof that achievements were enabled.true.Verification
Bastion/build: the two with a left panel returntrue; the card-only one returnsnullbecause that card predates Bastion#488.