Skip to content

feat(parser): report achievement challenge disabled notice - #51

Merged
Teakowa merged 2 commits into
mainfrom
feat/achievement-challenge-disabled
Oct 29, 2026
Merged

Teakowa merged 2 commits into
mainfrom
feat/achievement-challenge-disabled

Conversation

@e54-bot

@e54-bot e54-bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add the additive evidence field achievement_challenge_disabled. It is true when the game's 成就挑战已禁用 notice is read from the left panel or from the titles line of the settlement card. Otherwise it is null, so a missing notice is not proof that achievements were enabled.
  • Keep the notice out of the settlement card title candidates.
  • Pair with feat(hud): show achievement disabled notice on settlement card Bastion#488, which prints the notice on the card titles line, and the platform rule that fails title conditions when the field is true.

Verification

  • 438 tests pass, including new parser cases for both sources and for a missing notice.
  • Run on the three Bastion screenshots in Bastion/build: the two with a left panel return true; the card-only one returns null because that card predates Bastion#488.
  • The card parse is only tested on constructed text. There is no real screenshot of the new card yet.

Read the 成就挑战已禁用 notice from the left panel and expose it as the additive achievement_challenge_disabled evidence field. It is null when the notice is not read.
The titles line of the settlement card can carry the notice. Report it as achievement_challenge_disabled and keep it out of the title candidates.
@Teakowa
Teakowa merged commit 3b9413e into main Oct 29, 2026
2 checks passed
@Teakowa
Teakowa deleted the feat/achievement-challenge-disabled branch October 29, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants