Repository navigation
fix: say why publishing is disabled until R2 is confirmed - #45
Merged
Merged
Conversation
The button read publishConfirmed through a no-argument helper, so Svelte never re-evaluated it when the checkbox changed and it stayed disabled. Pass the state in explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish button stays disabled until the R2 confirmation checkbox is ticked, with no hint. After an owner override this looked like publishing was blocked, but the request was never sent. Adds a one-line hint, and notes that publishing creates a candidate version that still needs promotion to stable.