Repository navigation
feat(layout): read the real in-game player name from the right panel - #40
Merged
Merged
Conversation
… run code Newer HUDs print the real player name above the server load, while the bottom-left name can be a streamer-mode name. The server load ROI now spans both lines (layout v8/v3), real_player is parsed from the text before the server load label, and the server load that the extra line pushed out of the old ROI is read again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer HUD versions print the player's real in-game name on the right panel, between the run code and the server load, because the bottom-left name can be a streamer-mode name. A real 2560x1440 submission shows it (
云雀above服务器负载 47).server_load_panelnow spans y122-158 and covers both the name line and the server load line (the extra line had pushed the server load out of the old ROI, so it read asnull). Layout versions become1280x720-v8and1280x800-v3; the 16:10 layout got the same change.data.real_playerplus afields.real_playerevidence entry (source ROIserver_load_panel). It is the text before the服务器负载label andnullwhen the HUD prints no name or no label. OCRKit reports it next toviewer_playerand does not choose between them.Verification:
real_player云雀andserver_load47 (previouslynull), with all other fields unchanged.real_playerandserver_loadnullwithout spurious text. No older-HUD screenshot that prints a server load was available; that case is covered by parser and service tests with stubbed OCR text.Needs the owners before this ships:
owbastion.codessubmissionOcrQualityPolicy.supportedLayoutVersionsonly lists1280x720-v7and1280x800-v2. Deploying this before the platform accepts v8/v3 would make new submissions fail the layout gate. The platform should accept v8/v3 (and may readreal_player) first; I did not touch that repository.settlement-hud-v1. The HUD that prints the real name looks like a newer producer revision, which Bastion should name; I left the matrix revisions unchanged.Not included: the 21:9 support is a separate PR (#39), and there is no real older-HUD screenshot with a server load line in the fixtures.