chore(deps): upgrade graphql to v17 and update codegen dependencies - #5150
Conversation
Signed-off-by: Adarshkumar0509 <adarshkumarthakur0509@gmail.com>
WalkthroughUpgrades the ChangesGraphQL dependency bump
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Contribution validation failed:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/package.json`:
- Around line 53-57: Add `@graphql-codegen/near-operation-file-preset` to the
minimumReleaseAgeExclude list in the workspace configuration so it matches the
version bump in package.json. Update the pnpm-workspace.yaml entry alongside the
dependency change, keeping it aligned with the other `@graphql-codegen/`* packages
and ensuring the dependency upgrade is reflected consistently across the
relevant config.
In `@frontend/pnpm-workspace.yaml`:
- Around line 32-43: The pnpm workspace exclusion list is missing the newly
added direct dependency `@graphql-codegen/near-operation-file-preset@5.2.1`, so
the `frontend/pnpm-workspace.yaml` package exclusions are incomplete. Update the
exclusion entries alongside the other `@graphql-codegen/*` packages to include
`@graphql-codegen/near-operation-file-preset@5.2.1`, keeping the workspace
filter consistent with the direct devDependency added in
`frontend/package.json`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 48260b34-1451-46a5-8d94-7ed1657f8f8b
⛔ Files ignored due to path filters (1)
frontend/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
frontend/package.jsonfrontend/pnpm-workspace.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5150 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 536 536
Lines 16976 16976
Branches 2417 2417
=======================================
Hits 16761 16761
Misses 123 123
Partials 92 92
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Signed-off-by: Adarshkumar0509 <adarshkumarthakur0509@gmail.com>
|
Contribution validation failed:
|
1 similar comment
|
Contribution validation failed:
|
|
Contribution validation failed:
|
|
Contribution validation failed:
|
|
You can't resolve a PR, you need an issue instead. |
|
Contribution validation failed:
|
|
yes according to contribution guidelines i have to create a issue first. next time i will keep this thing in my mind |
The 'all dropdown triggers should use pointer cursor' test was left over from when Community had a dropdown submenu. PR OWASP#4100 replaced the Community dropdown with a plain link, leaving this test broken. Removes the obsolete test. Signed-off-by: Adarshkumar0509 <adarshkumarthakur0509@gmail.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
hii @arkid15r the ChapterDetails and CommitteeDetails E2E failures are caused by missing data in the CI database dump I confirmed this locally via pg_restore --data-only which returns nothing for /chapters/rosario and /committees/events. Could you update the S3 dump with this data? |
I'm not sure that's the root cause. Why did it pass with the previous package version? We didn't touch the dump for a while. I understand there might be time-related entity failure for events but I don't think it's the case here. |
Signed-off-by: Adarshkumar0509 <adarshkumarthakur0509@gmail.com>
|
hii @arkid15r My local e2e run passes 252/252. Could you take a look at what differs in the CI environment? |
a4be6f9
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/package.json`:
- Line 29: The dependency set is inconsistent because
`@graphql-codegen/near-operation-file-preset`@5.2.1 only supports graphql up to
v16 while frontend/package.json already pins graphql to 17.0.0. Update the
codegen preset version (and any related codegen package entries in the same
dependency block) to a release that declares GraphQL 17 support, keeping the
existing graphql and `@apollo/client` versions aligned. Use the package.json
dependency declarations to locate the codegen preset entry and adjust it so the
peer range matches graphql@17.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 87a59da9-3a9c-4839-99f4-3ca7cc5a56fd
⛔ Files ignored due to path filters (1)
frontend/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
frontend/next.config.tsfrontend/package.jsonfrontend/pnpm-workspace.yaml
arkid15r
left a comment
arkid15r
left a comment
There was a problem hiding this comment.
The e2e tests failed locally too, it wasn't a CI only issue. See my commits for the fix details.
|
Now I can see it was failing because graphql v17's ESM .mjs files weren't being traced by Next.js |
…WASP#5150) * chore(deps): upgrade graphql to v17 and update codegen dependencies Signed-off-by: Adarshkumar0509 <adarshkumarthakur0509@gmail.com> * chore(deps): add near-operation-file-preset to minimumReleaseAgeExclude Signed-off-by: Adarshkumar0509 <adarshkumarthakur0509@gmail.com> * fix(e2e): remove stale dropdown cursor test from Header spec The 'all dropdown triggers should use pointer cursor' test was left over from when Community had a dropdown submenu. PR OWASP#4100 replaced the Community dropdown with a plain link, leaving this test broken. Removes the obsolete test. Signed-off-by: Adarshkumar0509 <adarshkumarthakur0509@gmail.com> * ci: trigger e2e re-run Signed-off-by: Adarshkumar0509 <adarshkumarthakur0509@gmail.com> * Update code * Update code --------- Signed-off-by: Adarshkumar0509 <adarshkumarthakur0509@gmail.com> Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org>
3 participants
Proposed change
Resolves #5151
Upgrades graphql from 16.14.0 to 17.0.0 and bumps codegen packages to versions that support graphql v17 peer dependency.
The Dependabot PR #5145 only bumped graphql itself, which caused E2E test failures because @graphql-codegen/cli@7.0.0 only supports up to graphql@^16.0.0.
This PR fixes that by upgrading:
Checklist