Replace call to 'which' for Windows (native)#69
Open
Conversation
Member
Author
|
This problem popped up again when testing Ruff!. |
Member
Author
|
Will this be merged or do you plan to implement another solution to the problem? |
Member
Author
|
@JimLewis is this implemented as a different solution (then we can close this PR) or will it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSVVM-Script calls
whichalso on Windows platforms when it tries to find e.g. the GHDL executable and version. As reported in the past, this doesn't work on Windows e.g. in PowerShell, because Windows does not provide awhichexecutable.This PR implements the functionality of
whichby splitting$PATHinto multiple directories. Each directory is checked if it containsghdl.exe. If so, the TCL variableghdlis set as before.It was checked with TCL 9.0.2 and running TCL from PowerShell.