use longest match instead of endsWith#5146
Draft
simonLeary42 wants to merge 1 commit intoOSC:masterfrom
Draft
Conversation
Contributor
Author
|
marked as draft until I add test cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You would think that the argument would be a form token, but actually it's a string that may or may not start with a form token:
ondemand/apps/dashboard/app/javascript/dynamic_forms.js
Line 757 in 87e93f6
But then later during an edge case, the argument is expected to also /end/ with a form token:
ondemand/apps/dashboard/app/javascript/dynamic_forms.js
Line 778 in 87e93f6
So sometimes it's OK to pass a string
ClusterFoo, but other times it's only ok to pass a form tokenCluster. I don't think this makes sense. A more reliable way to handle this edge case would be to compare the string length of the matched tokens.