remove queues from auto_queues using {Allow,Deny}Qos 2#5137
Draft
simonLeary42 wants to merge 5 commits intoOSC:masterfrom
Draft
remove queues from auto_queues using {Allow,Deny}Qos 2#5137simonLeary42 wants to merge 5 commits intoOSC:masterfrom
simonLeary42 wants to merge 5 commits intoOSC:masterfrom
Conversation
simonLeary42
changed the title
simonLeary42
force-pushed
the
remove-auto-queues-allowqos-denyqos5
branch
from
755e8a1 to
5b42f11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #4471
closes #3932
Also fixes a little inconsistency where account_allowed takes into account deny_accounts as well as allow_accounts , while blocked_queue only takes into account allow_accounts.
tests will not pass until #5135 is merged.
I took some liberties with the structure of the test cases. The current fixture data is (imo) opaque and fragile, I would much rather work with partitions/QoSes/accounts whose names have useful meaning and whose properties should always stay the same.