Maksud/resolve updated interface - #1
Open
maksud wants to merge 4 commits into
Open
Conversation
added 2 commits
May 15, 2025 17:46
shakedregev
reviewed
Jul 31, 2025
| A_->setDataPointers(const_cast<int*>(ia), const_cast<int*>(ja), const_cast<Number*>(A_->getValues(ReSolve::memory::HOST)), ReSolve::memory::HOST); | ||
|
|
||
| #if RESOLVE_WITH_GPU | ||
| if (method_ == resolve_rf || method_ == resolve_rf_fgmres || method_ == resolve_glu) { |
Collaborator
There was a problem hiding this comment.
We might want to just check if it's not glu, in case we add another refactorization method.
shakedregev
reviewed
Jul 31, 2025
shakedregev
left a comment
shakedregev
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, I will test it.
pelesh
requested changes
Aug 7, 2025
pelesh
left a comment
pelesh
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Please replace hard-wired print statements with Ipopt output and remove commented out code.
|
|
||
| if (method_ == resolve_rf_fgmres) | ||
| { | ||
| printf("Resolve::FGMRES Setup\n"); |
Collaborator
There was a problem hiding this comment.
Perhaps we should use Ipopt's output and not hard-wire these print statements.
Comment on lines
+305
to
306
| printf("First Iteration: %d: Performing KLU Factorization\n", n_iteration_); | ||
| // Symbolic Factorization |
Collaborator
There was a problem hiding this comment.
Replace hard-wired print statement with Ipopt output function.
Comment on lines
+335
to
336
| // std::cout << "%" << n_iteration_ << "%" << "KLU FULL FACTORIZATION" << std::endl; | ||
| status = resolve_KLU_->factorize(); |
Collaborator
There was a problem hiding this comment.
Remove commented out code from the PR.
Collaborator
|
Please give instructions how to run the tests from scratch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code refactoring and cleanup. Removed test codes. Tested with ReSolve interface. Tested on HIP and CUDA devices.