Skip to content

Lower verbosity for Phasor Dynamics testing - #548

Open
lukelowry wants to merge 2 commits into
developfrom
lukel/pd-test-logging-dev
Open

Lower verbosity for Phasor Dynamics testing#548
lukelowry wants to merge 2 commits into
developfrom
lukel/pd-test-logging-dev

Conversation

@lukelowry

Copy link
Copy Markdown
Collaborator

Description

Addresses #527 and #528.

Proposed changes

Set verbosity to NONE before the expected failure tests

Further comments

@nkoukpaizan This does not fully address the open issues but it helps with the usability concern, I think. Let me know what you think

@lukelowry
lukelowry requested a review from nkoukpaizan August 24, 2026 17:01
@nkoukpaizan nkoukpaizan added bug Something isn't working testing labels Aug 24, 2026
@nkoukpaizan
nkoukpaizan requested a review from pelesh August 24, 2026 18:26
@nkoukpaizan nkoukpaizan added this to the Release 0.2 milestone Aug 24, 2026
@nkoukpaizan

Copy link
Copy Markdown
Collaborator

A few comments:

  • Setting the verbosity to NONE in main for the tests may be too broad. Perhaps add some comments in the code to the effect this being a temporary solution and how one might change this setting to get more verbose outputs.
  • Note that we are still printing messages, e.g., Testing expected ESDC1A missing-bus configuration error., even though the errors have been suppressed.
  • This addresses the two linked issues, but the excessive output concern applies to several other tests, e.g., PhasorDynamicsExciterEsdc1aTest.

@lukelowry

Copy link
Copy Markdown
Collaborator Author

@nkoukpaizan I see, how about my change in ca00d14? Changes back to previous verbosity

noteExpectedLogs("Testing REPCA defaults, parameter floors, and invalid "
"configurations. Logged errors and warnings are expected.");
const auto previous_verbosity = Log::verbosity();
// Use EVERYTHING to inspect diagnostics from the invalid cases below.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Use EVERYTHING to inspect diagnostics from the invalid cases below.
// Changing the verbosity to NONE to suppress expected errors and warning for the following tests.
// Use EVERYTHING to inspect diagnostics from the invalid cases below.

I like having a comment here. I recommend adding something to this effect to other instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants