Lower verbosity for Phasor Dynamics testing - #548
Open
lukelowry wants to merge 2 commits into
Open
Conversation
Collaborator
|
A few comments:
|
Collaborator
Author
|
@nkoukpaizan I see, how about my change in ca00d14? Changes back to previous verbosity |
nkoukpaizan
reviewed
Aug 24, 2026
| noteExpectedLogs("Testing REPCA defaults, parameter floors, and invalid " | ||
| "configurations. Logged errors and warnings are expected."); | ||
| const auto previous_verbosity = Log::verbosity(); | ||
| // Use EVERYTHING to inspect diagnostics from the invalid cases below. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Use EVERYTHING to inspect diagnostics from the invalid cases below. | |
| // Changing the verbosity to NONE to suppress expected errors and warning for the following tests. | |
| // Use EVERYTHING to inspect diagnostics from the invalid cases below. |
I like having a comment here. I recommend adding something to this effect to other instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #527 and #528.
Proposed changes
Set verbosity to
NONEbefore the expected failure testsFurther comments
@nkoukpaizan This does not fully address the open issues but it helps with the usability concern, I think. Let me know what you think