Skip to content

Refine IDATest::consistentICType test for steady-state initialization - #543

Merged
nkoukpaizan merged 9 commits into
steven/ida-initfrom
nicholson/ida-init
Aug 19, 2026
Merged

Refine IDATest::consistentICType test for steady-state initialization#543
nkoukpaizan merged 9 commits into
steven/ida-initfrom
nicholson/ida-init

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This modifies the IDATest::consistentICType model to something that admits a steady-state solution to exercise both IdaConsistentICType::Y and IdaConsistentICType::YA_YDP.

More minor suggestion to tighten the IDA tolerance and use isEqual with default criteria.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • [N/A] The CHANGELOG.md has been updated to reflect the changes. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

Feel free to adjust/enhance as you see fit.

@nkoukpaizan nkoukpaizan added the enhancement New feature or request label Aug 19, 2026
@nkoukpaizan nkoukpaizan changed the title Nicholson/ida init Refine IDATest::consistentICType test for steady-state initialization Aug 19, 2026
Steven-Roberts
Steven-Roberts reviewed Aug 19, 2026
View reviewed changes
Comment thread tests/UnitTests/Solver/Dynamic/IdaTests.hpp Outdated
@nkoukpaizan
nkoukpaizan merged commit 7ff6b9e into steven/ida-init Aug 19, 2026
6 checks passed
nkoukpaizan added a commit that referenced this pull request Aug 21, 2026
@Steven-Roberts @nkoukpaizan
Add option for IDA consistent initial conditions mode (#542)
55a709e 
* Add option to pick IDA initialization type

* Remove functions to be more descriptive

* Remove AUTO

* Update changelog

* Align table columns

* Apply pre-commit fixes

* Refine IDATest::consistentICType test for steady-state initialization (#543)

* std::abs--> isEqual

* Make all checks explicity in IDATest::consistentICType, including unchanged states.

* Add test for IDATest::consistentICType with initially consistent derivative.

* Change IDATest::consistentICType model to something that admits a steady-state solution.

* Increasing consistentICType tolerances.

* Update tolerance comment.

---------

Co-authored-by: nkoukpaizan <nkoukpaizan@users.noreply.github.com>

---------

Co-authored-by: Steven-Roberts <Steven-Roberts@users.noreply.github.com>
Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com>
Co-authored-by: nkoukpaizan <nkoukpaizan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Steven-Roberts Steven-Roberts Steven-Roberts approved these changes

Assignees

@Steven-Roberts Steven-Roberts

@nkoukpaizan nkoukpaizan

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nkoukpaizan @Steven-Roberts