Add option for IDA consistent initial conditions mode - #542
Merged
Conversation
nkoukpaizan
reviewed
Aug 18, 2026
nkoukpaizan
left a comment
nkoukpaizan
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me in terms of providing the option to set the initialization type. I am not sure that if addresses the underlying question about steady-state initialization.
…#543) * std::abs--> isEqual * Make all checks explicity in IDATest::consistentICType, including unchanged states. * Add test for IDATest::consistentICType with initially consistent derivative. * Change IDATest::consistentICType model to something that admits a steady-state solution. * Increasing consistentICType tolerances. * Update tolerance comment. --------- Co-authored-by: nkoukpaizan <nkoukpaizan@users.noreply.github.com>
nkoukpaizan
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed Monday, this adds the option to pick between IDA's two modes for computing consistent initial conditions.
Proposed changes
This add
Ida::setConsistentICType(IdaConsistentICType consistent_ic_type)and a correspondingconsistent_ic_typeJSON property to set the mode. It keeps thebool findConsistentargument toIda::initializeSimulation, so it is still possible to skip the solve.Checklist
-Wall -Wpedantic -Wconversion -Wextra.